From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lndn.lancelotsix.com (vps-42846194.vps.ovh.net [IPv6:2001:41d0:801:2000::2400]) by sourceware.org (Postfix) with ESMTPS id DF89A3858D35 for ; Wed, 4 Jan 2023 16:18:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DF89A3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=lancelotsix.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lancelotsix.com Received: from ubuntu.lan (unknown [IPv6:2a02:390:9086::146]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id D30C48018A; Wed, 4 Jan 2023 16:18:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=lancelotsix.com; s=2021; t=1672849130; bh=fA3RUd/z0rsrJQ+unM8kHaoOLEJI1i93XT99l0ukdMI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AvR+bbgm1EMaF7GEkUyaMpazQ2SYoGbr/rSdPxeEa9p34BWl+1xKOm7ATJErvSn1F Ze1xDEfwyslc9JtTC2uw7EY+rd315E3wuQJk2JWNErSzYhi+ZZ5j9nJFm16O/brlDX X845zTGytRPcyGVh4TC3dj84KWfS/i2evz3DT42Gv9nyBKyGGjrJHwQctp5/2mujfd 4RyyymhOZmG/DGv3JBm2fgvWglrNGulNaNY2P882IKTXQQEAXjM7LGBoNycTbd26VE yqH1PLroV/kXdVtxvw+jn7+91tTf/vg/pMvIwJd/MFsXItNdF44i989jzbyZvCS91I wseODeVqR/E1A== Date: Wed, 4 Jan 2023 16:18:44 +0000 From: Lancelot SIX To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: use gdb_test_multiple in gdb_breakpoint Message-ID: <20230104161817.qbvbspsqcqrjw6w2@ubuntu.lan> References: <20230103192216.108444-1-simon.marchi@polymtl.ca> <20230104091559.rqo2774ba566j5sg@ubuntu.lan> <9b050608-4bb6-dbc3-69f6-ebc9ad2cc303@polymtl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9b050608-4bb6-dbc3-69f6-ebc9ad2cc303@polymtl.ca> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11 (lndn.lancelotsix.com [0.0.0.0]); Wed, 04 Jan 2023 16:18:50 +0000 (UTC) X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Oh, right, I missed that. I folded the test name in the > gdb_test_multiple call (removed the test_name var) and used > $gdb_test_name in the fail call. I updated the patch locally. Should I > add your Reviewed-By after those changes? > > Simon > Yes, with those change, feel free to add Reviewed-By: Lancelot Six Best, Lancelot.