From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D3F3F3858D35 for ; Thu, 5 Jan 2023 01:29:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D3F3F3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672882167; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XHJ6uHiiGYmYjl01vXdhqZ/kjR76BKBhZrbOQ95xAwY=; b=ZG4bT+iHfN2TPXGal5q57JTUVfH5TUXDcqtWlDHhCa75VKfudoPJYlG0zbphJ8KvkHGjOO lqtUid6uL/j6Bskd5jOYO1ZpV9eJciy7PdwVIBIOGgkAKlKHdUaILUrV+Y1RDPCknDPf0R ktXpmi77qyZMiYlsR4KZ8FRblEkAuSA= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-562-Ds9RXgClOwerILcLjfZfVw-1; Wed, 04 Jan 2023 20:29:26 -0500 X-MC-Unique: Ds9RXgClOwerILcLjfZfVw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 05E2E29A9D35; Thu, 5 Jan 2023 01:29:26 +0000 (UTC) Received: from f37-zws-1 (unknown [10.2.16.55]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AF74F2166B30; Thu, 5 Jan 2023 01:29:25 +0000 (UTC) Date: Wed, 4 Jan 2023 18:29:23 -0700 From: Kevin Buettner To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 00/46] Rewrite "require" test procedure and use it more often Message-ID: <20230104182923.79a512ef@f37-zws-1> In-Reply-To: <20221217000818.3729389-1-tom@tromey.com> References: <20221217000818.3729389-1-tom@tromey.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 16 Dec 2022 17:07:32 -0700 Tom Tromey wrote: > Let me know what you think. Overall, I like this series. One thing that I find a little odd (due to a sort of double negation) is the construct: require !skip_something ...which replaces something like: if {[skip_something]} { unsupported "target does not support something" return 0 } I see that Markus Metzger also commented on this and also that you noted that this could be improved over time. (Which is fine with me.) I looked at each patch in the series, though I didn't read all of them closely. After a while, I just did some spot checks to make sure that they were doing what I expected. So... LGTM. Kevin