public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: gdb-patches@sourceware.org
Cc: Pedro Alves <pedro@palves.net>,
	Simon Marchi <simon.marchi@efficios.com>,
	Andrew Burgess <aburgess@redhat.com>
Subject: [PATCH v2 2/8] gdb: make install_breakpoint return a non-owning reference
Date: Thu,  5 Jan 2023 15:02:31 -0500	[thread overview]
Message-ID: <20230105200237.987771-3-simon.marchi@polymtl.ca> (raw)
In-Reply-To: <20230105200237.987771-1-simon.marchi@polymtl.ca>

From: Pedro Alves <pedro@palves.net>

A following patch will want to install a breakpoint and then keep a
non-owning reference to it.  Make install_breakpoint return a non-owning
reference, to make that easy.

Co-Authored-By: Simon Marchi <simon.marchi@efficios.com>
Change-Id: I2e8106a784021ff276ce251e24708cbdccc2d479
Approved-By: Andrew Burgess <aburgess@redhat.com>
---
 gdb/breakpoint.c | 4 +++-
 gdb/breakpoint.h | 8 +++++---
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 8cfc46e0bed4..5778a5c64dfb 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -7956,7 +7956,7 @@ catchpoint::catchpoint (struct gdbarch *gdbarch, bool temp,
   pspace = current_program_space;
 }
 
-void
+breakpoint *
 install_breakpoint (int internal, std::unique_ptr<breakpoint> &&arg, int update_gll)
 {
   breakpoint *b = add_to_breakpoint_chain (std::move (arg));
@@ -7969,6 +7969,8 @@ install_breakpoint (int internal, std::unique_ptr<breakpoint> &&arg, int update_
 
   if (update_gll)
     update_global_location_list (UGLL_MAY_INSERT);
+
+  return b;
 }
 
 static int
diff --git a/gdb/breakpoint.h b/gdb/breakpoint.h
index 7289a09e95c5..93267a1d177f 100644
--- a/gdb/breakpoint.h
+++ b/gdb/breakpoint.h
@@ -1480,10 +1480,12 @@ extern void
    target and breakpoint_created observers of its existence.  If
    INTERNAL is non-zero, the breakpoint number will be allocated from
    the internal breakpoint count.  If UPDATE_GLL is non-zero,
-   update_global_location_list will be called.  */
+   update_global_location_list will be called.
 
-extern void install_breakpoint (int internal, std::unique_ptr<breakpoint> &&b,
-				int update_gll);
+   Takes ownership of B, and returns a non-owning reference to it.  */
+
+extern breakpoint *install_breakpoint
+  (int internal, std::unique_ptr<breakpoint> &&b, int update_gll);
 
 /* Returns the breakpoint ops appropriate for use with with LOCSPEC
    and according to IS_TRACEPOINT.  Use this to ensure, for example,
-- 
2.39.0


  parent reply	other threads:[~2023-01-05 20:02 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-05 20:02 [PATCH v2 0/8] Initial support for ROCm platform (AMD GPU) debugging Simon Marchi
2023-01-05 20:02 ` [PATCH v2 1/8] gdb: add supports_arch_info callback to gdbarch_register Simon Marchi
2023-01-05 20:02 ` Simon Marchi [this message]
2023-01-05 20:02 ` [PATCH v2 3/8] gdbsupport: add type definitions for pid, lwp and tid Simon Marchi
2023-01-05 20:02 ` [PATCH v2 4/8] gdb: add inferior_pre_detach observable Simon Marchi
2023-01-05 20:02 ` [PATCH v2 5/8] gdb: add gdbarch_up Simon Marchi
2023-01-05 20:31   ` Tom Tromey
2023-01-05 20:36     ` Simon Marchi
2023-01-05 20:41       ` Tom Tromey
2023-01-06  0:48         ` Simon Marchi
2023-01-05 20:02 ` [PATCH v2 6/8] gdb/solib-svr4: don't disable probes interface if probe not found Simon Marchi
2023-01-05 20:02 ` [PATCH v2 7/8] gdb: make gdb_printing_disassembler::stream public Simon Marchi
2023-01-05 20:02 ` [PATCH v2 8/8] gdb: initial support for ROCm platform (AMDGPU) debugging Simon Marchi
2023-01-05 20:17   ` Simon Marchi
2023-01-25 17:03 ` [PATCH v2 0/8] Initial support for ROCm platform (AMD GPU) debugging Simon Marchi
2023-02-02 15:08   ` Simon Marchi
2023-02-06 11:47     ` Tom de Vries
2023-02-06 14:01       ` Lancelot Six
2023-02-06 16:53         ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230105200237.987771-3-simon.marchi@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@palves.net \
    --cc=simon.marchi@efficios.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).