From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 10E8F3858C5E for ; Thu, 5 Jan 2023 20:02:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 10E8F3858C5E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 305K2enX009521 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 5 Jan 2023 15:02:44 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 305K2enX009521 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1672948965; bh=JHHu0gTzjmav1GImSuvq8iQiL6pQV8huXdRmLDtiALk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=D+3MthO8k6smqXt07ZgMCH8vf7P4UTwJh2zO+u/YYH11kXho3hYYhl+liNVX3lFih hNxhyRTmfkgQy+GAEjnAnepidhtQGTP3nF8vGKJ48EXNb1DpZJvqmOx6POo07B995v VsBKZflfyGRA/lOBmroWl0RYUrINQsCnnCZOEgRc= Received: from simark.localdomain (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 21D4A1E223; Thu, 5 Jan 2023 15:02:40 -0500 (EST) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi , Andrew Burgess Subject: [PATCH v2 3/8] gdbsupport: add type definitions for pid, lwp and tid Date: Thu, 5 Jan 2023 15:02:32 -0500 Message-Id: <20230105200237.987771-4-simon.marchi@polymtl.ca> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230105200237.987771-1-simon.marchi@polymtl.ca> References: <20230105200237.987771-1-simon.marchi@polymtl.ca> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 5 Jan 2023 20:02:40 +0000 X-Spam-Status: No, score=-3189.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: From: Simon Marchi A following patch will want to declare variables of the same type as some ptid_t components. To make that easy (and avoid harcoding those types everywhere), define some type definitions in the ptid_t struct for each of them. Use them throughout ptid.h. I initially used pid_t, lwp_t and tid_t, but there is the risk of some system defining the pid_t type using a macro instead of a typedef, which would break things. So, use the _type suffix instead. Change-Id: I820b0bea9dafcb4914f1c9ba4bb96b5c666c8dec Approved-By: Andrew Burgess --- gdbsupport/ptid.h | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/gdbsupport/ptid.h b/gdbsupport/ptid.h index 365e11c6db5e..aa296b83181c 100644 --- a/gdbsupport/ptid.h +++ b/gdbsupport/ptid.h @@ -39,6 +39,10 @@ class ptid_t { public: + using pid_type = int; + using lwp_type = long; + using tid_type = ULONGEST; + /* Must have a trivial defaulted default constructor so that the type remains POD. */ ptid_t () noexcept = default; @@ -48,13 +52,13 @@ class ptid_t A ptid with only a PID (LWP and TID equal to zero) is usually used to represent a whole process, including all its lwps/threads. */ - explicit constexpr ptid_t (int pid, long lwp = 0, ULONGEST tid = 0) + explicit constexpr ptid_t (pid_type pid, lwp_type lwp = 0, tid_type tid = 0) : m_pid (pid), m_lwp (lwp), m_tid (tid) {} /* Fetch the pid (process id) component from the ptid. */ - constexpr int pid () const + constexpr pid_type pid () const { return m_pid; } /* Return true if the ptid's lwp member is non-zero. */ @@ -64,7 +68,7 @@ class ptid_t /* Fetch the lwp (lightweight process) component from the ptid. */ - constexpr long lwp () const + constexpr lwp_type lwp () const { return m_lwp; } /* Return true if the ptid's tid member is non-zero. */ @@ -74,7 +78,7 @@ class ptid_t /* Fetch the tid (thread id) component from a ptid. */ - constexpr ULONGEST tid () const + constexpr tid_type tid () const { return m_tid; } /* Return true if the ptid represents a whole process, including all its @@ -144,13 +148,13 @@ class ptid_t private: /* Process id. */ - int m_pid; + pid_type m_pid; /* Lightweight process id. */ - long m_lwp; + lwp_type m_lwp; /* Thread id. */ - ULONGEST m_tid; + tid_type m_tid; }; /* Functor to hash a ptid. */ -- 2.39.0