From: Simon Marchi <simon.marchi@polymtl.ca>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>,
Andrew Burgess <aburgess@redhat.com>
Subject: [PATCH v2 7/8] gdb: make gdb_printing_disassembler::stream public
Date: Thu, 5 Jan 2023 15:02:36 -0500 [thread overview]
Message-ID: <20230105200237.987771-8-simon.marchi@polymtl.ca> (raw)
In-Reply-To: <20230105200237.987771-1-simon.marchi@polymtl.ca>
From: Simon Marchi <simon.marchi@efficios.com>
In the ROCm port, we need to access the underlying stream of a
gdb_printing_disassembler, so make it public. The reason we need to
access it is to know whether it supports style escape code. We then
pass that information to a temporary string_file we use while
symbolizing addresses.
Change-Id: Ib95755a4a45b8f6478787993e9f904df60dd8dc1
Approved-By: Andrew Burgess <aburgess@redhat.com>
---
gdb/disasm.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gdb/disasm.h b/gdb/disasm.h
index 86d8eed61e90..02d940810771 100644
--- a/gdb/disasm.h
+++ b/gdb/disasm.h
@@ -123,12 +123,12 @@ struct gdb_printing_disassembler : public gdb_disassemble_info
{
DISABLE_COPY_AND_ASSIGN (gdb_printing_disassembler);
-protected:
-
/* The stream that disassembler output is being written too. */
struct ui_file *stream ()
{ return m_stream; }
+protected:
+
/* Constructor. All the arguments are just passed to the parent class.
We also add the two print functions to the arguments passed to the
parent. See gdb_disassemble_info for a description of how the
--
2.39.0
next prev parent reply other threads:[~2023-01-05 20:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 20:02 [PATCH v2 0/8] Initial support for ROCm platform (AMD GPU) debugging Simon Marchi
2023-01-05 20:02 ` [PATCH v2 1/8] gdb: add supports_arch_info callback to gdbarch_register Simon Marchi
2023-01-05 20:02 ` [PATCH v2 2/8] gdb: make install_breakpoint return a non-owning reference Simon Marchi
2023-01-05 20:02 ` [PATCH v2 3/8] gdbsupport: add type definitions for pid, lwp and tid Simon Marchi
2023-01-05 20:02 ` [PATCH v2 4/8] gdb: add inferior_pre_detach observable Simon Marchi
2023-01-05 20:02 ` [PATCH v2 5/8] gdb: add gdbarch_up Simon Marchi
2023-01-05 20:31 ` Tom Tromey
2023-01-05 20:36 ` Simon Marchi
2023-01-05 20:41 ` Tom Tromey
2023-01-06 0:48 ` Simon Marchi
2023-01-05 20:02 ` [PATCH v2 6/8] gdb/solib-svr4: don't disable probes interface if probe not found Simon Marchi
2023-01-05 20:02 ` Simon Marchi [this message]
2023-01-05 20:02 ` [PATCH v2 8/8] gdb: initial support for ROCm platform (AMDGPU) debugging Simon Marchi
2023-01-05 20:17 ` Simon Marchi
2023-01-25 17:03 ` [PATCH v2 0/8] Initial support for ROCm platform (AMD GPU) debugging Simon Marchi
2023-02-02 15:08 ` Simon Marchi
2023-02-06 11:47 ` Tom de Vries
2023-02-06 14:01 ` Lancelot Six
2023-02-06 16:53 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230105200237.987771-8-simon.marchi@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).