From: Aaron Merey <amerey@redhat.com>
To: gdb-patches@sourceware.org
Cc: Aaron Merey <amerey@redhat.com>
Subject: [PING*2][PATCH] gdb/linespec.c: Fix missing source file during breakpoint re-set
Date: Fri, 6 Jan 2023 18:56:07 -0500 [thread overview]
Message-ID: <20230106235607.498218-1-amerey@redhat.com> (raw)
In-Reply-To: <20221021170720.27249-1-amerey@redhat.com>
Ping. I tweaked the testcase so that it applies to the master branch.
Thanks,
Aaron
---
During breakpoint re-setting, the source_filename of an
explicit_location_spec is used to lookup the symtabs associated with
the breakpoint being re-set. This source_filename is compared with each
known symtab filename in order to retrieve the breakpoint's symtabs.
However the source_filename may have been originally copied from a
symtab's fullname (the path where GDB found the source file) when the
breakpoint was first created. If a breakpoint symtab's filename and
fullname differ and there is no substitute-path rule that converts the
fullname to the filename, this will cause a NOT_FOUND_ERROR to be thrown
during re-setting.
Fix this by using a symtab's filename to set the explicit_location_spec
source_filename instead of the symtab's fullname.
---
gdb/linespec.c | 4 ++--
gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp | 9 +++++++++
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/gdb/linespec.c b/gdb/linespec.c
index e9339c3338c..6db0f02e318 100644
--- a/gdb/linespec.c
+++ b/gdb/linespec.c
@@ -2283,13 +2283,13 @@ convert_linespec_to_sals (struct linespec_state *state, linespec *ls)
/* Make sure we have a filename for canonicalization. */
if (ls->explicit_loc.source_filename == NULL)
{
- const char *fullname = symtab_to_fullname (state->default_symtab);
+ const char *filename = state->default_symtab->filename;
/* It may be more appropriate to keep DEFAULT_SYMTAB in its symtab
form so that displaying SOURCE_FILENAME can follow the current
FILENAME_DISPLAY_STRING setting. But as it is used only rarely
it has been kept for code simplicity only in absolute form. */
- ls->explicit_loc.source_filename = xstrdup (fullname);
+ ls->explicit_loc.source_filename = xstrdup (filename);
}
}
else
diff --git a/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp b/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp
index 6d5af1370b0..bfe6e639e4f 100644
--- a/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp
+++ b/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp
@@ -224,6 +224,15 @@ proc_with_prefix local_url { } {
set lineno [gdb_get_line_number "Breakpoint here"]
gdb_test "list $lineno" "return 0;\[^\r\n\]+Breakpoint here\\. .*"
+ # Verify that a breakpoint re-sets correctly when the actual location
+ # of the source file in the debuginfod client cache differs from
+ # the contents of DW_AT_comp_dir and DW_AT_name.
+ gdb_test "set cwd $debugdir" "" "file [file tail $binfile] cwd"
+ gdb_test_no_output "del breakpoint 1"
+ gdb_test "break $lineno" "Breakpoint 2 at.*file.*"
+ gdb_test "run" "Breakpoint 2.*" \
+ "file [file tail $binfile] set breakpoint"
+
# GDB should now find the executable file.
clean_restart
gdb_test "core $::corefile" ".*return 0.*" "file [file tail $::corefile]" \
--
2.39.0
next prev parent reply other threads:[~2023-01-06 23:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 23:44 [PATCH] " Aaron Merey
2022-10-10 16:06 ` Bruno Larsen
2022-10-12 20:49 ` Aaron Merey
2022-10-13 7:59 ` Bruno Larsen
2022-10-14 0:47 ` Aaron Merey
2022-10-21 17:07 ` Aaron Merey
2023-01-06 23:56 ` Aaron Merey [this message]
2023-01-09 19:27 ` [PING*2][PATCH] " Tom Tromey
2023-01-10 1:15 ` Aaron Merey
2023-02-01 17:37 ` Andrew Burgess
2023-01-09 19:27 ` [PATCH] " Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230106235607.498218-1-amerey@redhat.com \
--to=amerey@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).