public inbox for
 help / color / mirror / Atom feed
From: Thiago Jung Bauermann <>
Cc: Thiago Jung Bauermann <>
Subject: [PATCH] gdb: Update with latest changes in gdbarch.c
Date: Wed, 11 Jan 2023 17:45:01 +0000	[thread overview]
Message-ID: <> (raw)

Commit 2b16913cdca2 ("gdb: make gdbarch_alloc take ownership of the tdep")
changed gdbarch.c without updating  As a result, running reverts those changes and causes the build to fail.

So change to generate the current version of gdbarch.c.
 gdb/ | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gdb/ b/gdb/
index d2bf86039d11..7dc79386940f 100755
--- a/gdb/
+++ b/gdb/
@@ -286,7 +286,7 @@ with open("gdbarch.c", "w") as f:
         print(f"  {c.type} {};", file=f)
     print("  /* target specific vector.  */", file=f)
-    print("  struct gdbarch_tdep_base *tdep = nullptr;", file=f)
+    print("  gdbarch_tdep_up tdep;", file=f)
     print("  gdbarch_dump_tdep_ftype *dump_tdep = nullptr;", file=f)
     print("  /* per-architecture data-pointers.  */", file=f)
@@ -316,13 +316,13 @@ with open("gdbarch.c", "w") as f:
     print("struct gdbarch *", file=f)
     print("gdbarch_alloc (const struct gdbarch_info *info,", file=f)
-    print("	       struct gdbarch_tdep_base *tdep)", file=f)
+    print("	       gdbarch_tdep_up tdep)", file=f)
     print("{", file=f)
     print("  struct gdbarch *gdbarch;", file=f)
     print("", file=f)
     print("  gdbarch = new struct gdbarch;", file=f)
-    print("  gdbarch->tdep = tdep;", file=f)
+    print("  gdbarch->tdep = std::move (tdep);", file=f)
     for c in filter(info, components):
         print(f"  gdbarch->{} = info->{};", file=f)

             reply	other threads:[~2023-01-11 17:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-11 17:45 Thiago Jung Bauermann [this message]
2023-01-11 18:42 ` Simon Marchi
2023-01-11 19:49   ` Thiago Jung Bauermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).