From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4AB7B3858D35 for ; Thu, 12 Jan 2023 03:56:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4AB7B3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673495810; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=REFjL2z/hh0edUKJHmulV5OyGX147LhuM6wtzQpBxkI=; b=K3uDCock+BxVcHeszvnFA+BHAoVyujMRkaDnjoE72s3qaq7cuZew+vRfusm0NF6ig5EQTz rkcesEfh7imAKkjnF+/t98bbLmEqXTcZOqNtURPQysuppeYM6QR0HM+THvv3lOP9s0LuOZ kjEN9DGdknDvWKkDFl2Dm7MzI7LFAi4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-336-zC7tJ3UnMlmBigo8wq7J2Q-1; Wed, 11 Jan 2023 22:56:49 -0500 X-MC-Unique: zC7tJ3UnMlmBigo8wq7J2Q-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 32FE385CBE0; Thu, 12 Jan 2023 03:56:49 +0000 (UTC) Received: from f37-zws-1 (unknown [10.2.17.76]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DD68A492C18; Thu, 12 Jan 2023 03:56:48 +0000 (UTC) Date: Wed, 11 Jan 2023 20:56:47 -0700 From: Kevin Buettner To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 08/79] Use require skip_cplus_tests Message-ID: <20230111205647.3f8b4306@f37-zws-1> In-Reply-To: <20230112030052.3306113-9-tom@tromey.com> References: <20230112030052.3306113-1-tom@tromey.com> <20230112030052.3306113-9-tom@tromey.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 11 Jan 2023 19:59:41 -0700 Tom Tromey wrote: > This changes some tests to use "require skip_cplus_tests". Well, technically, it's "require !skip_cplus_tests". E.g... > diff --git a/gdb/testsuite/gdb.base/advance-until-multiple-locations.exp b/gdb/testsuite/gdb.base/advance-until-multiple-locations.exp > index 181ab334be5..ef60fc67951 100644 > --- a/gdb/testsuite/gdb.base/advance-until-multiple-locations.exp > +++ b/gdb/testsuite/gdb.base/advance-until-multiple-locations.exp > @@ -18,7 +18,7 @@ > > standard_testfile .cc > > -if { [skip_cplus_tests] } { continue } > +require !skip_cplus_tests > > if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} \ > {debug c++}] } { It appears that the rest of the "Use require_skip..." patches have similar commit messages. I apologize for missing this while reviewing the earlier series. I don't think it's necessary to post a new series with adjusted messages. Kevin