From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B52E23858D35 for ; Thu, 12 Jan 2023 04:45:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B52E23858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673498721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IJvia0yvahtRLmS2C6fnduT1iftiLbW8nfX1bPIQ4p4=; b=iT9g/1EE/O4s21ch20aEpRxOzwjiH0SbrOPkWPguJ/clf+bAhuKKVuMkWAwip911pZ+2P7 RgX7+Kxd68HC+DVBQguDoNHG5HUx3QEdIlPPjWLAW++FIkWHfwb41sBE6uMrJGHDqD219c FIOcyReqAB7nGhsdByOR7sQSICTfHTQ= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-614-_KW48k-8OBeSw7_DPMIXzA-1; Wed, 11 Jan 2023 23:45:17 -0500 X-MC-Unique: _KW48k-8OBeSw7_DPMIXzA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4055C3811F3D; Thu, 12 Jan 2023 04:45:17 +0000 (UTC) Received: from f37-zws-1 (unknown [10.2.17.76]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E977B140EBF5; Thu, 12 Jan 2023 04:45:16 +0000 (UTC) Date: Wed, 11 Jan 2023 21:45:15 -0700 From: Kevin Buettner To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 00/79] Rewrite "require" test procedure and use it more often Message-ID: <20230111214515.73c0d4e6@f37-zws-1> In-Reply-To: <20230112030052.3306113-1-tom@tromey.com> References: <20230112030052.3306113-1-tom@tromey.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I've looked at each patch in this series, but only skimmed the ones with obviously mechanical changes. I did look more closely at the parts (in later patches) which changed testsuite/lib/gdb.exp. In addition to the nits that I found regarding the "Use require skip_..." commits, the same nits apply to the "Use require use_gdb_stub" and "Use require gdb_debug_enable" commits. E.g. for the "Use require use_gdb_stub" commit, the message says: This changes some tests to use "require use_gdb_stub". ...but the actual require statements are all of the form: require !use_gdb_stub I like the use of "gdb --configuration" for determining whether GDB has certain features (e.g. tui, guile, python). Aside from the nits mentioned above, LGTM. Kevin