public inbox for
 help / color / mirror / Atom feed
From: Abdul Basit Ijaz <>
Subject: [PATCH v4 0/1] gdb, testsuite: Fix arrays of variable length strings for FORTRAN
Date: Tue, 17 Jan 2023 23:34:29 +0100	[thread overview]
Message-ID: <> (raw)

Hi All,

V4 patch contains the updates based on Andrew recent feedback and
fix tests for updated data type of Fortran string arrays.

@Andrew thanks alot for the detailed feedback.  As per your feedback,
I have highlighed the issue in this patch using your changes and
updated the test to print and check rank value also for vla string
array.  This patch is majorly address string array so as you already
mentioned this patch would resolve issue for TYPE_CODE_STRING dynamic
arrays while for rest it can be fixed later propely.

V3 of this series can be found here:

Changes since V3:
* Update the code as per Andrew feedback to highlight the issue still
  exist in resolving dynamic arrays.
* Update the test to print and check rank of variable length string.
* Update gdb.fortran/string-types.exp and gdb.opt/fortran-string.exp
  tests to handle updated vla array ptype.

GDB Testsuite is executed using the patch and there is no regression
seen as compare to master on Ubuntu 18.04 machine for
unix/native-gdbserver and native-extended.gdbserver configurations.

Best Regards,
Abdul Basit

Abdul Basit Ijaz (1):
  gdb, testsuite: Fix arrays of variable length strings for FORTRAN

 gdb/c-valprint.c                           |  1 +
 gdb/gdbtypes.c                             | 45 ++++++++++++++--
 gdb/testsuite/gdb.fortran/string-types.exp |  4 +-
 gdb/testsuite/gdb.fortran/vla-array.exp    | 60 ++++++++++++++++++++++
 gdb/testsuite/gdb.fortran/vla-array.f90    | 45 ++++++++++++++++
 gdb/testsuite/gdb.opt/fortran-string.exp   |  2 +-
 6 files changed, 151 insertions(+), 6 deletions(-)
 create mode 100644 gdb/testsuite/gdb.fortran/vla-array.exp
 create mode 100644 gdb/testsuite/gdb.fortran/vla-array.f90


Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, <>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

                 reply	other threads:[~2023-01-17 22:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).