From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id 7A4BF3858D32 for ; Sun, 22 Jan 2023 21:56:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7A4BF3858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id F2CA31003FBA2 for ; Sun, 22 Jan 2023 21:56:09 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id JiJtp388miJ4bJiJtp6yaK; Sun, 22 Jan 2023 21:56:09 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=DfLSFthW c=1 sm=1 tr=0 ts=63cdb0f9 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=cTaJ2ebJ13e5enHCDM4A:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=S7QEr4bLWUH0aW8W0lgMUo3fn+dNlhWBt02F4ZZhtJM=; b=AiizSN1cJpaWDsC4KRrAvOYS3U z0awRX568KuURtnblGQBM54caCjpWof1dDfptkjqVkcx7op9zINO/rLgwn210BDAEpPOg5ZwyC6n+ eOAiK0XspI616NFuNNu1os4ML; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:55760 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pJiJt-003faM-Nr; Sun, 22 Jan 2023 14:56:09 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 1/8] Convert skip_altivec_tests to allow form Date: Sun, 22 Jan 2023 14:55:51 -0700 Message-Id: <20230122215558.1931803-2-tom@tromey.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230122215558.1931803-1-tom@tromey.com> References: <20230122215558.1931803-1-tom@tromey.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1pJiJt-003faM-Nr X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (localhost.localdomain) [97.122.76.186]:55760 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3027.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This renames skip_altivec_tests to allow_altivec_tests and updates its users to use require. --- gdb/testsuite/gdb.arch/altivec-abi.exp | 3 +- gdb/testsuite/gdb.arch/altivec-regs.exp | 4 +-- .../gdb.arch/powerpc-vector-regs.exp | 3 +- gdb/testsuite/lib/gdb.exp | 28 +++++++++---------- 4 files changed, 20 insertions(+), 18 deletions(-) diff --git a/gdb/testsuite/gdb.arch/altivec-abi.exp b/gdb/testsuite/gdb.arch/altivec-abi.exp index 28d0ae1fff9..1c3cda451e4 100644 --- a/gdb/testsuite/gdb.arch/altivec-abi.exp +++ b/gdb/testsuite/gdb.arch/altivec-abi.exp @@ -21,7 +21,8 @@ # This file uses altivec-abi.c for input. # -if {![istarget "powerpc*"] || [skip_altivec_tests]} { +require allow_altivec_tests +if {![istarget "powerpc*"]} { verbose "Skipping altivec abi tests." return } diff --git a/gdb/testsuite/gdb.arch/altivec-regs.exp b/gdb/testsuite/gdb.arch/altivec-regs.exp index 21e019122ce..8a7fd2e502c 100644 --- a/gdb/testsuite/gdb.arch/altivec-regs.exp +++ b/gdb/testsuite/gdb.arch/altivec-regs.exp @@ -21,8 +21,8 @@ # This file uses altivec-regs.c for input. # - -if {![istarget "powerpc*"] || [skip_altivec_tests]} { +require allow_altivec_tests +if {![istarget "powerpc*"]} { verbose "Skipping altivec register tests." return } diff --git a/gdb/testsuite/gdb.arch/powerpc-vector-regs.exp b/gdb/testsuite/gdb.arch/powerpc-vector-regs.exp index f9d404b4835..bbcf45a555d 100644 --- a/gdb/testsuite/gdb.arch/powerpc-vector-regs.exp +++ b/gdb/testsuite/gdb.arch/powerpc-vector-regs.exp @@ -20,7 +20,8 @@ # 0 to 31 in each of the 16 bytes of each corresponding register, and # we then check if gdb sees these same values. -if {![istarget "powerpc*"] || [skip_altivec_tests]} { +require allow_altivec_tests +if {![istarget "powerpc*"]} { verbose "Skipping PowerPC vector register tests." return } diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 3188f2de615..4346c858579 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -3457,18 +3457,18 @@ proc support_displaced_stepping {} { return 0 } -# Run a test on the target to see if it supports vmx hardware. Return 0 if so, -# 1 if it does not. Based on 'check_vmx_hw_available' from the GCC testsuite. +# Run a test on the target to see if it supports vmx hardware. Return 1 if so, +# 0 if it does not. Based on 'check_vmx_hw_available' from the GCC testsuite. -gdb_caching_proc skip_altivec_tests { +gdb_caching_proc allow_altivec_tests { global srcdir subdir gdb_prompt inferior_exited_re - set me "skip_altivec_tests" + set me "allow_altivec_tests" # Some simulators are known to not support VMX instructions. if { [istarget powerpc-*-eabi] || [istarget powerpc*-*-eabispe] } { - verbose "$me: target known to not support VMX, returning 1" 2 - return 1 + verbose "$me: target known to not support VMX, returning 0" 2 + return 0 } # Make sure we have a compiler that understands altivec. @@ -3477,8 +3477,8 @@ gdb_caching_proc skip_altivec_tests { } elseif [test_compiler_info xlc*] { set compile_flags "additional_flags=-qaltivec" } else { - verbose "Could not compile with altivec support, returning 1" 2 - return 1 + verbose "Could not compile with altivec support, returning 0" 2 + return 0 } # Compile a test program containing VMX instructions. @@ -3493,7 +3493,7 @@ gdb_caching_proc skip_altivec_tests { } } if {![gdb_simple_compile $me $src executable $compile_flags]} { - return 1 + return 0 } # Compilation succeeded so now run it via gdb. @@ -3506,22 +3506,22 @@ gdb_caching_proc skip_altivec_tests { gdb_expect { -re ".*Illegal instruction.*${gdb_prompt} $" { verbose -log "\n$me altivec hardware not detected" - set skip_vmx_tests 1 + set allow_vmx_tests 0 } -re ".*$inferior_exited_re normally.*${gdb_prompt} $" { verbose -log "\n$me: altivec hardware detected" - set skip_vmx_tests 0 + set allow_vmx_tests 1 } default { warning "\n$me: default case taken" - set skip_vmx_tests 1 + set allow_vmx_tests 0 } } gdb_exit remote_file build delete $obj - verbose "$me: returning $skip_vmx_tests" 2 - return $skip_vmx_tests + verbose "$me: returning $allow_vmx_tests" 2 + return $allow_vmx_tests } # Run a test on the power target to see if it supports ISA 3.1 instructions -- 2.39.0