From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 8BAD23858D32 for ; Mon, 23 Jan 2023 07:59:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8BAD23858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 74A691F385 for ; Mon, 23 Jan 2023 07:59:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1674460780; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Cfl1rofNa/ohM6JSQ0rPYLyAqywBor7s75QSNYA9Xp0=; b=h8dU3KixZZ1VMiEV0EPRhUwHclZiNtZoYMnU3AQVcawl9KOZMOZGlMominCt4pNkzhtrRz Y7U11fmjoySLc4QktTEoRz5p42DMXfefIIuaW688nYrGbDRTy3haa36Xv2PPPYbXiRIpWZ WpaG9ky/oEdZJe2eGCJy5YbfrEIwJ5s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1674460780; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Cfl1rofNa/ohM6JSQ0rPYLyAqywBor7s75QSNYA9Xp0=; b=tEN9R+dlWcxjbKIZrgiOaugrlThXOSZUoLu+Rlc5e6Wlzm7ihk6lFZIj3BgH+/svsiaqIO MzuAPjvLhAUbK1Cw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 62975134F5 for ; Mon, 23 Jan 2023 07:59:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Yb/0Fmw+zmOLRAAAMHmgww (envelope-from ) for ; Mon, 23 Jan 2023 07:59:40 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [pushed] [gdb/testsuite] Fix untested in gdb.base/frame-view.exp Date: Mon, 23 Jan 2023 08:59:39 +0100 Message-Id: <20230123075939.1771-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: When running test-case gdb.base/frame-view.exp, I see: ... gdb compile failed, ld: frame-view0.o: in function `main': frame-view.c:73: undefined reference to `pthread_create' ld: frame-view.c:76: undefined reference to `pthread_join' collect2: error: ld returned 1 exit status UNTESTED: gdb.base/frame-view.exp: failed to prepare ... Fix this by adding pthreads to the compilation flags. Tested on x86_64-linux. --- gdb/testsuite/gdb.base/frame-view.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.base/frame-view.exp b/gdb/testsuite/gdb.base/frame-view.exp index edae16735ab..72955bd1aff 100644 --- a/gdb/testsuite/gdb.base/frame-view.exp +++ b/gdb/testsuite/gdb.base/frame-view.exp @@ -18,7 +18,7 @@ standard_testfile if { [build_executable "failed to prepare" \ - ${testfile} ${srcfile}] } { + ${testfile} ${srcfile} {debug pthreads}] } { return } base-commit: 7e538762c2c1f2e5c4be31b9ec7d99cc4fbabf7f -- 2.35.3