From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by sourceware.org (Postfix) with ESMTPS id 83F513858D28 for ; Tue, 24 Jan 2023 14:17:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 83F513858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674569832; x=1706105832; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=G3MSL9emfUcXYEzrAC0RkXQVm7gIh2yGA0mxCx8Vh1M=; b=BAE2dNzjFQIiHuGp1l2EVo8HvQHPYj+eZ5QHtarr87m2NBtMPLLltzWe j54mi3gPyYEpdj9BA8sy+JCME1Ea4xuP2K3SONkdKgLxFX5Xq4NEBE22A JaAMJ5+IBG7nDSCU6AMPJ0evTTYs42Fd6UGs61SUuItPlbM++8dLWVQXt 3NxgyHT5ekCXOvzinXRhOB0MLCk9QmSr6LLHRLIBAyq6rRrf+ZlY1So7c 6/H/Tj57rlX12NeD/+3c9R9CsneePo5rxrWU71vf1xi4J7HymaKDtxB0q Uy/+OHnqI6YPGidy2zTQ6bS4y61jftJGs7QXQY6fjvmdpsaBaB1Q7Zyxz Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10599"; a="309875138" X-IronPort-AV: E=Sophos;i="5.97,242,1669104000"; d="scan'208";a="309875138" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2023 06:17:11 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10599"; a="725486934" X-IronPort-AV: E=Sophos;i="5.97,242,1669104000"; d="scan'208";a="725486934" Received: from mulvlfelix.iul.intel.com (HELO localhost) ([172.28.48.92]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2023 06:17:09 -0800 From: Felix Willgerodt To: gdb-patches@sourceware.org Cc: Felix Willgerodt Subject: [PATCH 1/1] gdb, i386: Update stale comment in i386-tdep.h. Date: Tue, 24 Jan 2023 15:16:50 +0100 Message-Id: <20230124141650.2459324-1-felix.willgerodt@intel.com> X-Mailer: git-send-email 2.34.3 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The comment seems no longer valid, the functions technically check for non-pseudo registers, like zmmh. Which is a valid use case. This could also be considered obvious, but the 32-bit register code is a bit complex to understand. --- gdb/i386-tdep.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/i386-tdep.h b/gdb/i386-tdep.h index 82de5faa988..371bce72369 100644 --- a/gdb/i386-tdep.h +++ b/gdb/i386-tdep.h @@ -353,7 +353,7 @@ enum record_i386_regnum /* Types for i386-specific registers. */ extern struct type *i387_ext_type (struct gdbarch *gdbarch); -/* Checks of different pseudo-registers. */ +/* Checks of different registers. */ extern int i386_byte_regnum_p (struct gdbarch *gdbarch, int regnum); extern int i386_word_regnum_p (struct gdbarch *gdbarch, int regnum); extern int i386_dword_regnum_p (struct gdbarch *gdbarch, int regnum); -- 2.34.3 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928