From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 3792F3858D28 for ; Tue, 24 Jan 2023 21:49:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3792F3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: by gnu.wildebeest.org (Postfix, from userid 1000) id 2C3DE302BBEC; Tue, 24 Jan 2023 22:49:37 +0100 (CET) Date: Tue, 24 Jan 2023 22:49:37 +0100 From: Mark Wielaard To: Simon Marchi Cc: gdb-patches@sourceware.org, John Baldwin , Sam James , Tom Tromey Subject: Re: [PATCHv3] gdb: Replace memcpy with std::copy to avoid some g++ warnings on sparc Message-ID: <20230124214937.GH11538@gnu.wildebeest.org> References: <20230124201624.875658-1-mark@klomp.org> <2f5e28eb-a5f2-0995-506f-b6632333c7b2@simark.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2f5e28eb-a5f2-0995-506f-b6632333c7b2@simark.ca> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-3037.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Simon, On Tue, Jan 24, 2023 at 04:29:20PM -0500, Simon Marchi wrote: > > diff --git a/gdb/fbsd-tdep.c b/gdb/fbsd-tdep.c > > index 203390d9880..ebc15543149 100644 > > --- a/gdb/fbsd-tdep.c > > +++ b/gdb/fbsd-tdep.c > > @@ -662,8 +662,9 @@ fbsd_make_note_desc (enum target_object object, uint32_t structsize) > > return buf; > > > > gdb::byte_vector desc (sizeof (structsize) + buf->size ()); > > - memcpy (desc.data (), &structsize, sizeof (structsize)); > > - memcpy (desc.data () + sizeof (structsize), buf->data (), buf->size ()); > > + std::copy (&structsize, &structsize + sizeof (structsize), desc.data ()); > > + std::copy (buf->data (), desc.data () + sizeof (structsize), > > + desc.data () + sizeof (structsize)); > > I think the second argument to the second std::copy call should have > `buf->data ()`, not `desc.data (). Otherwise, LGTM. However, it would > be nice to have the approval from John Baldwin. Bah, what a stupid typo. You are right of course. Sorry. v4 coming up. Thanks, Mark