From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id DEC5A3858C39 for ; Wed, 25 Jan 2023 08:49:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DEC5A3858C39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: by gnu.wildebeest.org (Postfix, from userid 1000) id AE551302BBEC; Wed, 25 Jan 2023 09:49:28 +0100 (CET) Date: Wed, 25 Jan 2023 09:49:28 +0100 From: Mark Wielaard To: Tom Tromey Cc: gdb-patches@sourceware.org, Simon Marchi , Sam James , John Baldwin Subject: Re: [PATCHv4] gdb: Replace memcpy with std::copy to avoid some g++ warnings on sparc Message-ID: <20230125084928.GI11538@gnu.wildebeest.org> References: <20230124223130.982276-1-mark@klomp.org> <87zga7ikx7.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zga7ikx7.fsf@tromey.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-3031.9 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Tom, On Tue, Jan 24, 2023 at 04:15:32PM -0700, Tom Tromey wrote: > >>>>> "Mark" == Mark Wielaard writes: > > Mark> - memcpy (desc.data () + sizeof (structsize), buf->data (), buf->size ()); > ... > Mark> + std::copy (buf->data (), buf->data () + sizeof (structsize), > Mark> + desc.data () + sizeof (structsize)); > > I think this should probably copy buf->size() bytes. > So maybe buf->begin() and buf->end() ? OK, sounds good. Will post a v5. Cheers, Mark