public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [pushed] [gdb/testsuite] Allow debug srcfile2 in gdb.base/unwind-on-each-insn.exp
@ 2023-01-25 14:24 Tom de Vries
  0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2023-01-25 14:24 UTC (permalink / raw)
  To: gdb-patches

Test-case gdb.base/unwind-on-each-insn.exp compiles $srcfile with debug info, and
$srcfile2 without.

Occasionally, I try both files with debug info:
...
-             $srcfile $debug_flags $srcfile2 $nodebug_flags]]} {
+             $srcfile $debug_flags $srcfile2 $debug_flags]]} {
...

This shortcuts the test due to no longer recognizing that stepi still lands
in foo.

Fix this by determining whether still in foo by checking the info frame output.

Tested on x86_64-linux.
---
 gdb/testsuite/gdb.base/unwind-on-each-insn.exp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gdb/testsuite/gdb.base/unwind-on-each-insn.exp b/gdb/testsuite/gdb.base/unwind-on-each-insn.exp
index d6f90dde8c1..059967a2b2e 100644
--- a/gdb/testsuite/gdb.base/unwind-on-each-insn.exp
+++ b/gdb/testsuite/gdb.base/unwind-on-each-insn.exp
@@ -142,9 +142,11 @@ proc do_test { function step_cmd } {
 		break
 	    }
 
+	    gdb_test $step_cmd
+
 	    set in_fn 0
-	    gdb_test_multiple $step_cmd "" {
-		-re -wrap "$::hex in $function \\(\\)" {
+	    gdb_test_multiple "info frame" "" {
+		-re -wrap "rip = $::hex in ${function}( \\(.*\\))?;.*" {
 		    set in_fn 1
 		}
 		-re -wrap "" {}

base-commit: 621271c7819c3337e3eb5e48b7a7ee66573543da
-- 
2.35.3


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-01-25 14:24 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-25 14:24 [pushed] [gdb/testsuite] Allow debug srcfile2 in gdb.base/unwind-on-each-insn.exp Tom de Vries

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).