Re: [PATCHv5] gdb: Replace memcpy with std::copy to avoid some g++ warnings on sparc

[Mark Wielaard <mark@klomp.org>]

Hi Hannes,

On Wed, Jan 25, 2023 at 12:00:05PM +0000, Hannes Domani wrote:
>  Am Mittwoch, 25. Januar 2023 um 09:56:03 MEZ hat Mark Wielaard <mark@klomp.org> Folgendes geschrieben:
> 
> >   gdb::byte_vector desc (sizeof (structsize) + buf->size ());
> > -  memcpy (desc.data (), &structsize, sizeof (structsize));
> > -  memcpy (desc.data () + sizeof (structsize), buf->data (), buf->size ());
> > +  std::copy (&structsize, &structsize + sizeof (structsize), desc.data ());
> 
> structsize is of type uint32_t, so wouldn't that effectively copy 4*4 bytes, instead of just 4?
> 
> Shouldn't it rather look like this?:
> 
>   std::copy (&structsize, &structsize + 1, desc.data ());

Aha, yeah, std::copy acts on the whole elements of the input. Maybe
less confusing to just keep using memcpy here. It is only the second
memcpy that produces the issue on sparc. That also brings down the fix
to a simple oneliner. Will sent a v6.

Thanks,

Mark