public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] gdb: Replace memcpy with std::copy to avoid some g++ warnings on sparc
@ 2023-01-25 21:27 Mark Wielaard
  2023-01-30 18:52 ` Tom Tromey
  0 siblings, 1 reply; 2+ messages in thread
From: Mark Wielaard @ 2023-01-25 21:27 UTC (permalink / raw)
  To: gdb-patches
  Cc: Simon Marchi, Sam James, Tom Tromey, John Baldwin, Hannes Domani,
	Mark Wielaard

For some reason g++ 12.2.1 on sparc produces spurious warnings for
stringop-overread and restrict in fbsd-tdep.c for a memcpy call.
Use std::copy to avoid the warnings:

In function ‘void* memcpy(void*, const void*, size_t)’,
    inlined from ‘gdb::optional<std::vector<unsigned char, gdb::default_init_allocator<unsigned char, std::allocator<unsigned char> > > > fbsd_make_note_desc(target_object, uint32_t)’ at ../../binutils-gdb/gdb/fbsd-tdep.c:666:10:
/usr/include/bits/string_fortified.h:29:33: error: ‘void* __builtin_memcpy(void*, const void*, long unsigned int)’ specified bound 18446744073709551612 exceeds maximum object size 9223372036854775807 [-Werror=stringop-overflow=]

In function ‘void* memcpy(void*, const void*, size_t)’,
    inlined from ‘gdb::optional<std::vector<unsigned char, gdb::default_init_allocator<unsigned char, std::allocator<unsigned char> > > > fbsd_make_note_desc(target_object, uint32_t)’ at ../../binutils-gdb/gdb/fbsd-tdep.c:673:10:
/usr/include/bits/string_fortified.h:29:33: error: ‘void* __builtin_memcpy(void*, const void*, long unsigned int)’ accessing 18446744073709551612 bytes at offsets 0 and 0 overlaps 9223372036854775801 bytes at offset -9223372036854775805 [-Werror=restrict]

gdb/ChangeLog:

	* fbsd-tdep.c (fbsd_make_note_desc): Use std::copy instead
	of memcpy.
---

 V6: Only use std::copy for the second memcpy
 V5: Use buf->begin (), buf->end () in second std::copy
 V4: Fix std::copy argument typo
 V3: Drop diagnostic suppressions just use std::copy
 V2: Fix typos and add example errors to commit messages

 gdb/fbsd-tdep.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/fbsd-tdep.c b/gdb/fbsd-tdep.c
index 203390d9880..3a7cb9b14ea 100644
--- a/gdb/fbsd-tdep.c
+++ b/gdb/fbsd-tdep.c
@@ -663,7 +663,7 @@ fbsd_make_note_desc (enum target_object object, uint32_t structsize)
 
   gdb::byte_vector desc (sizeof (structsize) + buf->size ());
   memcpy (desc.data (), &structsize, sizeof (structsize));
-  memcpy (desc.data () + sizeof (structsize), buf->data (), buf->size ());
+  std::copy (buf->begin (), buf->end (), desc.data () + sizeof (structsize));
   return desc;
 }
 
-- 
2.31.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] gdb: Replace memcpy with std::copy to avoid some g++ warnings on sparc
  2023-01-25 21:27 [PATCH] gdb: Replace memcpy with std::copy to avoid some g++ warnings on sparc Mark Wielaard
@ 2023-01-30 18:52 ` Tom Tromey
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2023-01-30 18:52 UTC (permalink / raw)
  To: Mark Wielaard
  Cc: gdb-patches, Simon Marchi, Sam James, Tom Tromey, John Baldwin,
	Hannes Domani

>>>>> "Mark" == Mark Wielaard <mark@klomp.org> writes:

Mark> For some reason g++ 12.2.1 on sparc produces spurious warnings for
Mark> stringop-overread and restrict in fbsd-tdep.c for a memcpy call.
Mark> Use std::copy to avoid the warnings:

Thank you.  This is ok.

Tom

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-01-30 18:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-25 21:27 [PATCH] gdb: Replace memcpy with std::copy to avoid some g++ warnings on sparc Mark Wielaard
2023-01-30 18:52 ` Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).