[PATCH v2 0/3] Fix Ada tasking for baremetal targets using Ravenscar threads

["Kévin Le Gouguec" <legouguec@adacore.com>]

Changes since v1:

* New patch to add a header for functions defined in ada-tasks.c.
* New patch to expose a getter for ada_tasks_pspace_data.
* Tweak original patch to use that getter from ravenscar-thread.c.

This ensures we do not introduce a function that refers to global
state; instead, we let ada_get_runtime_cpu_index's caller get its
hands "dirty".


I considered exposing ada_tasks_pspace_data entirely and making
ada_get_runtime_cpu_index a method as discussed, but AFAIU this would
have required either

  (a) keeping all members of that struct public so that existing
  functions can keep accessing them,

  (b) ponder which members ought to remain public, which should not,
  and which portions of ada-tasks.c should be turned into methods for
  ada_tasks_pspace_data.

(a) does not sound like progress in terms of encapsulation; I am not
confident I can get (b) done soon.  Hence the opaque pointer as a
first step toward (b).

Will stay on the lookout for opportunities to refactor uses of that
struct into "method-like" functions, make members private when it
makes sense, and finally, expose the struct definition, turning the
"method-like" functions into methods.


Tried to follow the coding conventions re. #include strategies;
apologies if I've missed something there, or anywhere else.


Kévin Le Gouguec (3):
  gdb: Introduce ada-tasks.h for functions defined in ada-tasks.c
  gdb/ada-tasks: Make the ada_tasks_pspace_data getter public
  gdb: Fix Ada tasking for baremetal targets using Ravenscar threads

 gdb/ada-lang.h             | 25 +++--------
 gdb/ada-tasks.c            | 44 +++++++++---------
 gdb/ada-tasks.h            | 91 ++++++++++++++++++++++++++++++++++++++
 gdb/breakpoint.c           |  1 +
 gdb/guile/scm-breakpoint.c |  2 +-
 gdb/mi/mi-main.c           |  2 +-
 gdb/python/py-breakpoint.c |  2 +-
 gdb/ravenscar-thread.c     | 17 +++++--
 8 files changed, 134 insertions(+), 50 deletions(-)
 create mode 100644 gdb/ada-tasks.h

-- 
2.25.1