From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 70F993858D33 for ; Tue, 7 Feb 2023 10:42:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 70F993858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9CB812090C for ; Tue, 7 Feb 2023 10:42:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1675766525; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=q3tARzjx9jJ4WHKWsenKbTmngay/98L5p4Vwt/rPZ5E=; b=dvk3xxXLxDMSlpGJk84F7FAiDlJKvaFMZHftBwhcfODZwI8rQufJIZQJIMq/oV0Jul6wn3 +FBiFqrDIMOm2+mJfejtzEX++2HjP1mwiK0Zx18TkygwRXQNhiIp/Z8GMdiJDCS+1ss7BZ ee5Dr0+KQbaBP74/nki8yxR7NvCVlNI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1675766525; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=q3tARzjx9jJ4WHKWsenKbTmngay/98L5p4Vwt/rPZ5E=; b=8D7c2VOoNfURBNUfe8qatgBu9ghN6NaLWvOYPENeGQnTXzARFi9R0BrTLc1zgULTU9oKsw O6lDjDA0b9fnY5Bw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8883313467 for ; Tue, 7 Feb 2023 10:42:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id WB4mIP0q4mOYKQAAMHmgww (envelope-from ) for ; Tue, 07 Feb 2023 10:42:05 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [pushed] [gdb/testsuite] Improve untested message in gdb.ada/finish-var-size.exp Date: Tue, 7 Feb 2023 11:42:05 +0100 Message-Id: <20230207104205.25747-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I came across: ... UNTESTED: gdb.ada/finish-var-size.exp: GCC too told for this test ... The message only tells us that the compiler version too old, not what compiler version is required. Fix this by rewriting using required: ... UNSUPPORTED: gdb.ada/finish-var-size.exp: require failed: \ expr [gcc_major_version] >= 12 ... Tested on x86_64-linux. --- gdb/testsuite/gdb.ada/finish-var-size.exp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/gdb/testsuite/gdb.ada/finish-var-size.exp b/gdb/testsuite/gdb.ada/finish-var-size.exp index c1cf6406433..5865be249a0 100644 --- a/gdb/testsuite/gdb.ada/finish-var-size.exp +++ b/gdb/testsuite/gdb.ada/finish-var-size.exp @@ -18,10 +18,7 @@ load_lib "ada.exp" require allow_ada_tests # GCC 12 has the needed fix. -if {![test_compiler_info {gcc-1[2-9]-*}]} { - untested "GCC too told for this test" - return -1 -} +require {expr [gcc_major_version] >= 12} standard_ada_testfile p base-commit: e7a881b9d49f16bd901dba53006c48a8bfd115df -- 2.35.3