From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by sourceware.org (Postfix) with ESMTPS id BA8FB3858D33 for ; Tue, 7 Feb 2023 12:17:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BA8FB3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675772269; x=1707308269; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=zyXxKcEzU9XdRHMKiUe2rECYSiokMzd0mfRyCJvq+/E=; b=AT1hX6hotghUjnIlpYupArWe2m/qP6qMu9THHYZJ7wOxCOusR4/x/Kwc kGbQR0LBNmCBAkVKl2GIefccOu4EBpGDNmca5e09BsuKr9bl1lPDeEJyT K6aBlzbcloGSg1cUnRu94Py3GN8ILQawE/Mx4PCa0SShLXdG9OHm/PVf8 7NMBiUlqp1ai1tOVoyt4XdkC+ipbkbOLUSi2wuiEGZw4E4vzdWknwB6hu /ythnBbDadyOnv6DK3580hh7ZY9pyv79iFxoh++1RQgVVGM+O3qFAcUi/ kXUEzjLArb5xAe540R71Uf22C3TCcS7cR5h3HYTYLg10EyCkXGsdBeCu/ Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="415709525" X-IronPort-AV: E=Sophos;i="5.97,278,1669104000"; d="scan'208";a="415709525" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2023 04:17:47 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="912309179" X-IronPort-AV: E=Sophos;i="5.97,278,1669104000"; d="scan'208";a="912309179" Received: from labpc2315.iul.intel.com (HELO localhost) ([172.28.50.57]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2023 04:17:46 -0800 From: Christina Schimpe To: gdb-patches@sourceware.org Cc: Christina Schimpe Subject: [PATCH 1/1] gdb, testsuite: Remove unnecessary call of "set print pretty on" Date: Tue, 7 Feb 2023 13:14:25 +0100 Message-Id: <20230207121425.3779898-1-christina.schimpe@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The command has no effect for the loading of GDB pretty printers and is removed by this patch to avoid confusion. Documentation for "set print pretty" "Cause GDB to print structures in an indented format with one member per line" --- gdb/testsuite/gdb.python/pretty-print-call-by-hand.exp | 4 ---- .../py-autoloaded-pretty-printers-in-newobjfile-event.exp | 2 -- 2 files changed, 6 deletions(-) diff --git a/gdb/testsuite/gdb.python/pretty-print-call-by-hand.exp b/gdb/testsuite/gdb.python/pretty-print-call-by-hand.exp index 7ab2b1facf7..01ee7b9d3d2 100644 --- a/gdb/testsuite/gdb.python/pretty-print-call-by-hand.exp +++ b/gdb/testsuite/gdb.python/pretty-print-call-by-hand.exp @@ -50,8 +50,6 @@ proc start_test { breakpoint_comment } { gdb_breakpoint [gdb_get_line_number ${breakpoint_comment} ${testfile}.c ] gdb_continue_to_breakpoint ${breakpoint_comment} ".*" - gdb_test_no_output "set print pretty on" "starting to pretty print" - set remote_python_file [gdb_remote_download host ${srcdir}/${subdir}/${testfile}.py] gdb_test_no_output "source ${remote_python_file}" "load python file" @@ -64,8 +62,6 @@ with_test_prefix "run to frame" { untested "couldn't run to main" } - gdb_test_no_output "set print pretty on" "starting to pretty print" - set remote_python_file [gdb_remote_download host ${srcdir}/${subdir}/${testfile}.py] gdb_test_no_output "source ${remote_python_file}" "load python file" diff --git a/gdb/testsuite/gdb.python/py-autoloaded-pretty-printers-in-newobjfile-event.exp b/gdb/testsuite/gdb.python/py-autoloaded-pretty-printers-in-newobjfile-event.exp index 2217e2e6527..eefa99c8fa1 100644 --- a/gdb/testsuite/gdb.python/py-autoloaded-pretty-printers-in-newobjfile-event.exp +++ b/gdb/testsuite/gdb.python/py-autoloaded-pretty-printers-in-newobjfile-event.exp @@ -61,8 +61,6 @@ gdb_test_no_output "source ${remote_python_event_handler_file}" "load python fil gdb_load ${binfile} -gdb_test_no_output "set print pretty on" - if { ![runto_main] } { return } -- 2.25.1 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928