From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy2-pub.mail.unifiedlayer.com (gproxy2-pub.mail.unifiedlayer.com [69.89.18.3]) by sourceware.org (Postfix) with ESMTPS id 1C4D73857365 for ; Mon, 13 Feb 2023 03:15:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1C4D73857365 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway4.mail.pro1.eigbox.com (Postfix) with ESMTP id 8FE2910047A44 for ; Mon, 13 Feb 2023 03:15:28 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id RPJQpJ4x0jkdRRPJQpCxhf; Mon, 13 Feb 2023 03:15:28 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=LPqj/La9 c=1 sm=1 tr=0 ts=63e9ab50 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10:nop_charset_1 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=7d_E57ReAAAA:8 a=FH1zNuIi26YjjqSCN6UA:9 a=QEXdDO2ut3YA:10:nop_charset_2 a=jhqOcbufqs7Y1TYCrUUU:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=IA6GgggiEahg6T3eFQKR2EV03NzSObqMAxsvFlXOhH0=; b=sAOWXPVgiqsCO9L07BSqfwxkej Q+MrXhlsPDKKM1QlT0kdZ8y4DOyHuWe3+k35lP+DiGYS9qMlObKDjRY/5BIzN9A//lceprKBWzO3r HwxFlFhfC0rOXybdatfI/y+Sd; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:37668 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pRPJQ-001AGJ-9e; Sun, 12 Feb 2023 20:15:28 -0700 From: Tom Tromey Date: Sun, 12 Feb 2023 20:15:35 -0700 Subject: [PATCH v3 19/50] Turn value_initialized and set_value_initialized functions into methods MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230209-submit-value-fixups-2023-v3-19-45e91a20c742@tromey.com> References: <20230209-submit-value-fixups-2023-v3-0-45e91a20c742@tromey.com> In-Reply-To: <20230209-submit-value-fixups-2023-v3-0-45e91a20c742@tromey.com> To: gdb-patches@sourceware.org Cc: Simon Marchi X-Mailer: b4 0.12.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pRPJQ-001AGJ-9e X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net ([192.168.0.21]) [75.166.130.93]:37668 X-Source-Auth: tom+tromey.com X-Email-Count: 41 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3027.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This changes the value_initialized and set_value_initialized functions to be methods of value. Approved-By: Simon Marchi --- gdb/c-valprint.c | 2 +- gdb/dwarf2/expr.c | 2 +- gdb/value.c | 16 ---------------- gdb/value.h | 15 +++++++++------ 4 files changed, 11 insertions(+), 24 deletions(-) diff --git a/gdb/c-valprint.c b/gdb/c-valprint.c index 0a9e4f49ba6..8cfb3786043 100644 --- a/gdb/c-valprint.c +++ b/gdb/c-valprint.c @@ -554,7 +554,7 @@ c_value_print (struct value *val, struct ui_file *stream, } } - if (!value_initialized (val)) + if (!val->initialized ()) gdb_printf (stream, " [uninitialized] "); if (options->objectprint && (type->code () == TYPE_CODE_STRUCT)) diff --git a/gdb/dwarf2/expr.c b/gdb/dwarf2/expr.c index 8d845e892e3..d6ad0f1776b 100644 --- a/gdb/dwarf2/expr.c +++ b/gdb/dwarf2/expr.c @@ -1057,7 +1057,7 @@ dwarf_expr_context::fetch_result (struct type *type, struct type *subobj_type, } } - set_value_initialized (retval, this->m_initialized); + retval->set_initialized (this->m_initialized); return retval; } diff --git a/gdb/value.c b/gdb/value.c index c56c04d448f..399e2d1e0b2 100644 --- a/gdb/value.c +++ b/gdb/value.c @@ -3799,22 +3799,6 @@ using_struct_return (struct gdbarch *gdbarch, != RETURN_VALUE_REGISTER_CONVENTION); } -/* Set the initialized field in a value struct. */ - -void -set_value_initialized (struct value *val, int status) -{ - val->m_initialized = status; -} - -/* Return the initialized field in a value struct. */ - -int -value_initialized (const struct value *val) -{ - return val->m_initialized; -} - /* Helper for value_fetch_lazy when the value is a bitfield. */ static void diff --git a/gdb/value.h b/gdb/value.h index 30c2cb48b70..e813970f9f5 100644 --- a/gdb/value.h +++ b/gdb/value.h @@ -316,6 +316,15 @@ struct value enum lval_type lval () const { return m_lval; } + /* Set or return field indicating whether a variable is initialized or + not, based on debugging information supplied by the compiler. + 1 = initialized; 0 = uninitialized. */ + int initialized () const + { return m_initialized; } + + void set_initialized (int value) + { m_initialized = value; } + /* Type of value; either not an lval, or one of the various different possible kinds of lval. */ @@ -657,12 +666,6 @@ extern void mark_value_bytes_optimized_out (struct value *value, extern void mark_value_bits_optimized_out (struct value *value, LONGEST offset, LONGEST length); -/* Set or return field indicating whether a variable is initialized or - not, based on debugging information supplied by the compiler. - 1 = initialized; 0 = uninitialized. */ -extern int value_initialized (const struct value *); -extern void set_value_initialized (struct value *, int); - /* Set COMPONENT's location as appropriate for a component of WHOLE --- regardless of what kind of lvalue WHOLE is. */ extern void set_value_component_location (struct value *component, -- 2.39.1