From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-820.bluehost.com (outbound-ss-820.bluehost.com [69.89.24.241]) by sourceware.org (Postfix) with ESMTPS id 132C93839DFF for ; Mon, 13 Feb 2023 03:54:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 132C93839DFF Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway2.mail.pro1.eigbox.com (Postfix) with ESMTP id 8A03710047FAF for ; Mon, 13 Feb 2023 03:54:10 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id RPuspcm57VjI3RPuspkmjV; Mon, 13 Feb 2023 03:54:10 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=AZZ0o1bG c=1 sm=1 tr=0 ts=63e9b462 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10:nop_charset_1 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=7d_E57ReAAAA:8 a=IgbvGzmsA9p6XoaW9xkA:9 a=QEXdDO2ut3YA:10:nop_charset_2 a=jhqOcbufqs7Y1TYCrUUU:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pvo6JN9xVXDZH+xA01WPRj7NzbZOCZR/CHWUiCOYxp0=; b=xxTcuFObxEsXwIjYCGAyAZRweh CN05zS6JEHoXgge9uQcgVsw5K8CUyn0xYTwUUexNQUjQPLLPcX4Su3Amy6bt7ctPEcqf9iTKZuz7j y2Bn5Hwps4zYxcg8K2heXfRqe; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:37668 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pRPJV-001AGJ-II; Sun, 12 Feb 2023 20:15:33 -0700 From: Tom Tromey Date: Sun, 12 Feb 2023 20:16:02 -0700 Subject: [PATCH v3 46/50] Make struct value data members private MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230209-submit-value-fixups-2023-v3-46-45e91a20c742@tromey.com> References: <20230209-submit-value-fixups-2023-v3-0-45e91a20c742@tromey.com> In-Reply-To: <20230209-submit-value-fixups-2023-v3-0-45e91a20c742@tromey.com> To: gdb-patches@sourceware.org Cc: Simon Marchi X-Mailer: b4 0.12.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pRPJV-001AGJ-II X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net ([192.168.0.21]) [75.166.130.93]:37668 X-Source-Auth: tom+tromey.com X-Email-Count: 98 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3027.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This hoists the 'private' in struct value to also encompass the data members. Approved-By: Simon Marchi --- gdb/value.h | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/gdb/value.h b/gdb/value.h index 225a3c851c4..7708530ddcc 100644 --- a/gdb/value.h +++ b/gdb/value.h @@ -609,6 +609,8 @@ struct value in the history. The value is removed from the value chain. */ int record_latest (); +private: + /* Type of value; either not an lval, or one of the various different possible kinds of lval. */ enum lval_type m_lval = not_lval; @@ -785,8 +787,6 @@ struct value loaded from the inferior. */ ULONGEST m_limited_length = 0; -private: - /* Allocate a value and its contents for type TYPE. If CHECK_SIZE is true, then apply the usual max-value-size checks. */ static struct value *allocate (struct type *type, bool check_size); @@ -806,15 +806,11 @@ struct value return failure here, which will ultimately throw an error. */ bool set_limited_array_length (); -public: /* Temporary */ - /* Allocate the contents of this value if it has not been allocated yet. If CHECK_SIZE is true, then apply the usual max-value-size checks. */ void allocate_contents (bool check_size); -private: - /* Helper function for value_contents_eq. The only difference is that this function is bit rather than byte based. -- 2.39.1