From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2066.outbound.protection.outlook.com [40.107.93.66]) by sourceware.org (Postfix) with ESMTPS id AA4423858C50 for ; Thu, 9 Feb 2023 11:26:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AA4423858C50 Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n60Jp1SLOPUbOru54/ICutyV5ye7ZNaxxuKEHyNOZ+/HB4mtxUKxZ9cA+4zqXdG3MpjHALTTQDsMmb+IBRPXC63NCNW+cGWLAuP9zPkIYlwAZNTpNguRXdw2UiAxRiuT4GfzxTAxNxPL/UPw3wgUBoFWM+WFOdaAwAZo7WhWLwWUW1IorhxwU1eOX/honkmi5FeqsKf6E7HqOE4XEtZxk3M1tkj3e7z/e4FN/pLNjPeASz02sh/scVJTk3hiyvEEfybADbp0fzqkfiPAPS+uxGz9SI075FiVBF4s1XQECRucwhysFrQaxz41zQg7+Bntz7O+Gb9lH5GYfbUoNkwIog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+xhVBkZmHbR1/2B+48/EAoa1A++3a/MY0nQ0TbRkiqk=; b=EuRUgurIcFnHWqLay2vC7Ll9B4sxSSfJkMthDOTCQ6MLR0vWijn521zCWV/rpLrbCGaFqA3xPbcaT2Jny8AOHXRFdOxnX/yRcPQVkTESWPivTl52NgSJJR4m5nlIF3qcEpdZxcfsc6oDneCryftuoQOCShtFmjAIAevp2Z8769A7TyXXS+UZFlzOrNU/rd03bMKmCRwbYkEDx+xA/EPNalLtucGA3gpj60Nk2R/XGF50IUDsyNzEqhay2CY7R5HziZ8wflao/OyDlWV4TsJMMOownVbiDNQI16AKTJNSVe3z6evPzj/7sWnCku8dPUaeZzaqgxdDlhCuJP/TBIWvlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=sourceware.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+xhVBkZmHbR1/2B+48/EAoa1A++3a/MY0nQ0TbRkiqk=; b=v2G1sv0f16DnFlysaJ1S3Xs9BIJxPIAoavVsFbiTnzAGG1t4/S5ymzm9PkhWMQIJmrNFAvk5yP4aOJb0QMaYPzfnyUEeip7O5OP9C38qD/gESYEF0QArQCr/1tmqRAxWbwUXjgAilqOub5ck0P0P557r29aJCaYpSh/mQbmhXHU= Received: from BN9PR03CA0162.namprd03.prod.outlook.com (2603:10b6:408:f4::17) by CH2PR12MB5003.namprd12.prod.outlook.com (2603:10b6:610:68::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.19; Thu, 9 Feb 2023 11:26:31 +0000 Received: from BL02EPF00010206.namprd05.prod.outlook.com (2603:10b6:408:f4:cafe::b9) by BN9PR03CA0162.outlook.office365.com (2603:10b6:408:f4::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.19 via Frontend Transport; Thu, 9 Feb 2023 11:26:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF00010206.mail.protection.outlook.com (10.167.241.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6086.16 via Frontend Transport; Thu, 9 Feb 2023 11:26:31 +0000 Received: from khazad-dum.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 9 Feb 2023 05:26:29 -0600 From: Lancelot SIX To: CC: , Lancelot SIX Subject: [PATCH v2 0/5] Fix gdb.rocm/simple.exp on hosts without ROCm Date: Thu, 9 Feb 2023 11:26:08 +0000 Message-ID: <20230209112613.922098-1-lancelot.six@amd.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00010206:EE_|CH2PR12MB5003:EE_ X-MS-Office365-Filtering-Correlation-Id: 7e17d536-dc96-4d20-6b0f-08db0a907e42 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: N8dhXsN8Vqk6Dxm4SzMGMUXjnS5t2NjSZ2/eOS8pGqFGuCbxflzCMPN7T2Dm6Ub/6BFcFZugnMAHEBDJJKDkxdzKIulb+50UAQ6eRAxytk/sClfC87ePTls/uXcV/JNcuc0yCxsoIlebL+qJar595eUUS+QFUqksmPJ++c++KXTH9nEHnblGi9BWnTxYvsD5/aj8K/3XJom1kiYzC4BSPKh5eWbq0cLvfQ878LeVxOJ+m8lzlvsZ7MK9TEwh0fdzOUDBsFgi0XeN32skDedOcsJez9m2VwHc5Z+okxtb1OdkDTgYzu4ffR77YjvUovvlPccXbnzyv8h3mLQx9ZBur9zqqCNIHtC3QQurAoweH0XzrNnABwN3MD4YhasUnSfgT1V/6RdQwiaKYbnd4SJkvSRDtNkJ3PZUF/udaAQ6dOhvo6f3XUW17V3ZI/yxRtvFsIKT6Xlul13RHrv0pd8e+w3CVdQxlOMhFn6imSb8RcKeFJpR85MYJ++jO1RYqcL/wBKBBZnx72yC82aTdNiQsScaZG47F4/hGpYLi6xEgI5QMm3Mn83AUYdB3fyPsKaJYFzJAkWSQqF9e+iExB/REI3HMX734brU9d6N3j1rYzzdczEhoASqleRM74mTFmOXNel9NA2qFp5emWp7wXHg/KdtZffvA7QV7b+j3NiZmTmdlVhliriagrZ4f7IhCWnrIaUbE+teIqU2ddABaXdN4EbQXgXrZy3pqse6xc21rRBPifGbAJYHUfOsJlhwxSHtmAsz3KuVeEsaCel87ggMZQP2AotPiOq0w8ueei6gBfZ9xUNlPycVbHgWm7NjOLoL X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(376002)(396003)(136003)(39860400002)(346002)(451199018)(40470700004)(46966006)(36840700001)(66899018)(84970400001)(6666004)(966005)(7696005)(36860700001)(40480700001)(36756003)(82310400005)(2906002)(54906003)(316002)(82740400003)(41300700001)(8936002)(5660300002)(81166007)(356005)(336012)(1076003)(186003)(26005)(83380400001)(2616005)(478600001)(16526019)(426003)(47076005)(6916009)(4326008)(86362001)(8676002)(40460700003)(70586007)(70206006)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 11:26:31.2439 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7e17d536-dc96-4d20-6b0f-08db0a907e42 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00010206.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB5003 X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, this is a V2 for https://sourceware.org/pipermail/gdb-patches/2023-February/196653.html. Changes since V1: - Fixed a typo in patch 1 - Removed the un-necessary "expr" call in patch 3 - Added patch 5 so both hipcc and rocm_agent_enumerator are searched in a consistent way Best, Lancelot. Hi, Tom De Vries reported that the gdb.rocm/simple.exp test (recently introduced with the AMDGPU support) can fails[1]. I can reproduce this problem (and variations of it) on systems where GDB is not build with the AMDGPU support, or which do not have the ROCm stack installed. This series fixes this test failure by only running the test if: - GDB is build with AMDGPU support (patch 1 and 3) - if the hipcc compiler is installed and can compile a simple HIP program which offloads a task to an AMDGPU device (patch 4). Patch 2 is a small refactoring to use "require" in gdb.rocm/*.exp. Patch 5 ensures that both hipcc (the hip compiler) and rocm_agent_enumerator (the tool to list AMDGPU devices) are searched in a consistent way. All feedbacks are welcome. Best, Lancelot. [1] https://sourceware.org/pipermail/gdb-patches/2023-February/196624.html Lancelot SIX (5): gdb: 'show config' shows --with[out]-amd-dbgapi gdb/testsuite: Rename skip_hipcc_tests to allow_hipcc_tests gdb/testsuite: require amd-dbgapi support to run rocm tests gdb/testsuite: allow_hipcc_tests tests the hipcc compiler gdb/testsuite: look for hipcc in env(ROCM_PATH) gdb/config.in | 3 ++ gdb/configure | 3 ++ gdb/configure.ac | 1 + gdb/testsuite/gdb.rocm/simple.exp | 5 +- gdb/testsuite/lib/future.exp | 7 ++- gdb/testsuite/lib/gdb.exp | 4 ++ gdb/testsuite/lib/rocm.exp | 80 +++++++++++++++++++++++++++++-- gdb/top.c | 10 ++++ 8 files changed, 104 insertions(+), 9 deletions(-) base-commit: c920e5cc604c5b20f9af7c75402eea94aa1e11c6 -- 2.34.1