From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2045.outbound.protection.outlook.com [40.107.102.45]) by sourceware.org (Postfix) with ESMTPS id E8E203858C62 for ; Thu, 9 Feb 2023 11:26:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E8E203858C62 Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GDGqu3uGuYfBzplsrjVXLMXap5SsW7+EOIj5RVKnPl6ic5w4wBSMlRXOebqufCZT9hjFUtaK97xz7cLiUkF1jEafiWSakPTZddxCMurHm4Vn22dibykH5eg8uKbIuUx3g47+brZHPx1pU/7O6M3JDI6KWh7p6kkwjzKBLfyKOpswM6bLRRo5PyrYjXgEMdmeQpvJdOhiASrvEadjQUXzcPBqocD7Ytct5d9YtiZuEVqipiUAQ8Mup3yj/mrPbMI9zdAd5vnmI2E9IV8snmmZFH4AFKEQH8mlTsZkEuPBlomf3pYQ035YnQEK7QbJFs9XEDXSVI/dVIbPZB5uGVzBPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q7mTO4EuVXGo/OFm6rX9KgorTaYbj3U5PEOS74iBr6E=; b=EQwRsktynVbC0nQcpGs/kfliYpULxBgkXTzXsfXJbP4mpL3QWMA1RPNjYaD1lWjluhr7+e+UnT5cZiS+Cs6pgVgW88M6w+mxBYVafjx8WZzg+Fc4apwXQ/PEMMN2AjVoKgf1YVyqvYHVV1ftBhuWEoYzJJtpzteR/66aaFlVwSSffXu1cA0e7XbFJ/0mhjpVtnNqbcurgTiXsRGn+/cFpziIUTcY9KjINzULEq3Dd1hLfziiAPoyMHR51LZDENYmxxqVCXmsfdurvtNcM4+XrZPWhN0nRAewu22dJLO14nrLueqKLYjGOSV62a7uUi2f2sV7gZa5dUyOMIrgHLovxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=sourceware.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q7mTO4EuVXGo/OFm6rX9KgorTaYbj3U5PEOS74iBr6E=; b=pPnCGQxMcG5++M0KcRVCu6zTQ3SlvC2q9RtSawmmPN3Y6xdGbQ4FvTYkepDk2nFhBsMycOCB0EdmSOnonlBJYoYVFjYBaW1Aq+421Y647rLvVc1WAVdiCn5UtAkQ3pa+NDZAwvz94Qkgo2B+6A0HAFAtiXwzKzsRL8LRnD6Jyd4= Received: from BN9PR03CA0172.namprd03.prod.outlook.com (2603:10b6:408:f4::27) by SJ0PR12MB6783.namprd12.prod.outlook.com (2603:10b6:a03:44e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36; Thu, 9 Feb 2023 11:26:34 +0000 Received: from BL02EPF00010206.namprd05.prod.outlook.com (2603:10b6:408:f4:cafe::91) by BN9PR03CA0172.outlook.office365.com (2603:10b6:408:f4::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.18 via Frontend Transport; Thu, 9 Feb 2023 11:26:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF00010206.mail.protection.outlook.com (10.167.241.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6086.16 via Frontend Transport; Thu, 9 Feb 2023 11:26:34 +0000 Received: from khazad-dum.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 9 Feb 2023 05:26:32 -0600 From: Lancelot SIX To: CC: , Lancelot SIX Subject: [PATCH v2 2/5] gdb/testsuite: Rename skip_hipcc_tests to allow_hipcc_tests Date: Thu, 9 Feb 2023 11:26:10 +0000 Message-ID: <20230209112613.922098-3-lancelot.six@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230209112613.922098-1-lancelot.six@amd.com> References: <20230209112613.922098-1-lancelot.six@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00010206:EE_|SJ0PR12MB6783:EE_ X-MS-Office365-Filtering-Correlation-Id: d66d6c31-2da9-4e4c-7f54-08db0a907ffb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ftl7TQth9nT/rpCvP2Qo9i3NgUit++zM69/e2Mocl7sUCocnUKQVSdyg3R309VVXhvkds/whyHA7HzuCt5cAWFjD97D4aQ4cf1PCcCzZgPwi3sI/Qyi9Etiz2yuxxg9KOEjwIQJlSkTBLaUx/fusPaMKDuD2+bRXEcyzpKcEzr2WoPvqoGOWOalP6qXkRGvo73/Oni1A2Kyds3zWhEA0yzxBhi+OG0q3yTKIyUPJRA52LLyBqWegE21oWVPHZV6NFzn4Ivsj5ZIWopFXZsIuqKGoDDdvUaOafVdxChLbPtSjOdgj6DCpvOu4Qtc83MwEWV/6V9ejMwRxzfQ/7XxRTn82yqk8/NK+/kZdslCYu6vOn2lW1EDaOOItiods/8RpgZt/F7pByf1I5PLbwuJd8NoiVipk658IgU7RuFdLMmXN4wN18eM1TAQeNPvXg/6kxj1Sv+e3ihkcQTSpUy5oMnW78jKQ1KrF8N0ztTzwk+XVc9TOlSIg4TyvKBN7RaUINcpg7dpwoci3HJeIWPAHyU563bEE005t2jH+1QihmmAIsAM5YmDk3aDf7PdGR6n0G6BZqBukUCZ2KtWBPpwOh/pmbINUuBe/GXpAA+rhoerIshsepL3OR7gTsBDl+/VNlwyCq2XWkIwwMTnOseHXxnDfa4OxAIfwmlCC1Lcw/uKhu0aKVtiWcx3CutlRG1+fMZhN5b/OfDZz414IyN1KFhj+DDcBRo9jn/laecm4nCwPTi08kXx4O9P8bJiOk+NfqLT7GZzHvsI96vq+GR71pA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(136003)(376002)(396003)(39860400002)(346002)(451199018)(40470700004)(46966006)(36840700001)(6916009)(70206006)(4326008)(70586007)(8676002)(36860700001)(336012)(40460700003)(316002)(83380400001)(54906003)(426003)(86362001)(5660300002)(81166007)(356005)(478600001)(1076003)(26005)(2906002)(186003)(36756003)(6666004)(16526019)(47076005)(84970400001)(41300700001)(82310400005)(82740400003)(8936002)(2616005)(7696005)(40480700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 11:26:34.1345 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d66d6c31-2da9-4e4c-7f54-08db0a907ffb X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00010206.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6783 X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Rename skip_hipcc_tests to allow_hipcc_tests so it can be used as a "require" predicate in tests. Use require in gdb.rocm/simple.exp. --- gdb/testsuite/gdb.rocm/simple.exp | 5 +---- gdb/testsuite/lib/rocm.exp | 6 +++--- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/gdb/testsuite/gdb.rocm/simple.exp b/gdb/testsuite/gdb.rocm/simple.exp index f84df71414e..befcc7aaabc 100644 --- a/gdb/testsuite/gdb.rocm/simple.exp +++ b/gdb/testsuite/gdb.rocm/simple.exp @@ -20,10 +20,7 @@ load_lib rocm.exp standard_testfile .cpp -if [skip_hipcc_tests] { - verbose "skipping hip test: ${testfile}" - return -} +require allow_hipcc_tests if {[build_executable "failed to prepare" $testfile $srcfile {debug hip}]} { return diff --git a/gdb/testsuite/lib/rocm.exp b/gdb/testsuite/lib/rocm.exp index e22f392deb1..1440ac85d32 100644 --- a/gdb/testsuite/lib/rocm.exp +++ b/gdb/testsuite/lib/rocm.exp @@ -15,14 +15,14 @@ # # Support library for testing ROCm (AMD GPU) GDB features. -proc skip_hipcc_tests { } { +proc allow_hipcc_tests { } { # Only the native target supports ROCm debugging. E.g., when # testing against GDBserver, there's no point in running the ROCm # tests. if {[target_info gdb_protocol] != ""} { - return 1 + return 0 } - return 0 + return 1 } # The lock file used to ensure that only one GDB has access to the GPU -- 2.34.1