From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [pushed] Trivially simplify rust_language::print_enum
Date: Thu, 9 Feb 2023 12:16:09 -0700 [thread overview]
Message-ID: <20230209191609.493729-1-tom@tromey.com> (raw)
rust_language::print_enum computes:
int nfields = variant_type->num_fields ();
... but then does not reuse this in one spot. This patch corrects the
oversight.
---
gdb/rust-lang.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/rust-lang.c b/gdb/rust-lang.c
index 6653f7a9c64..f2017f95211 100644
--- a/gdb/rust-lang.c
+++ b/gdb/rust-lang.c
@@ -495,7 +495,7 @@ rust_language::print_enum (struct value *val, struct ui_file *stream,
}
bool first_field = true;
- for (int j = 0; j < variant_type->num_fields (); j++)
+ for (int j = 0; j < nfields; j++)
{
if (!first_field)
gdb_puts (", ", stream);
--
2.39.1
reply other threads:[~2023-02-09 19:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230209191609.493729-1-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).