From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy3-pub.mail.unifiedlayer.com (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42]) by sourceware.org (Postfix) with ESMTPS id 7BE963858CDB for ; Tue, 14 Feb 2023 20:23:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7BE963858CDB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway5.mail.pro1.eigbox.com (Postfix) with ESMTP id E7510100406DD for ; Tue, 14 Feb 2023 20:23:40 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id S1q0pQQ6qNX2aS1q0pAqmy; Tue, 14 Feb 2023 20:23:40 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=NMAQR22g c=1 sm=1 tr=0 ts=63ebedcc a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10:nop_charset_1 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=Lz-IZ8fpgrDb48-hSZIA:9 a=QEXdDO2ut3YA:10:nop_charset_2 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7kex1QjUr2FNt3E1R7Hk2Rad3Ev3xQ/F/ClxnL0MCVc=; b=pmcrS5i6heNIey2ZoAUvTMiQmL AnOx89GidGG0af9U51WKRaO17FTXNYMUSYQi8wvCvECCtMoE9rPgslD3x09iiNUH3K/QrXYvQvopD csd9kmHcCo8/l/RUND91UHZa+; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:49794 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pS1q0-002zny-Ou for gdb-patches@sourceware.org; Tue, 14 Feb 2023 13:23:40 -0700 From: Tom Tromey Date: Tue, 14 Feb 2023 13:23:34 -0700 Subject: [PATCH 4/6] Change value::m_stack to bool MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230214-submit-more-value-stuff-v1-4-2fb85efbaa72@tromey.com> References: <20230214-submit-more-value-stuff-v1-0-2fb85efbaa72@tromey.com> In-Reply-To: <20230214-submit-more-value-stuff-v1-0-2fb85efbaa72@tromey.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pS1q0-002zny-Ou X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net ([192.168.0.21]) [75.166.130.93]:49794 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3027.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This changes value::m_stack to be a bool and updates the various uses. --- gdb/dwarf2/expr.c | 2 +- gdb/frame-unwind.c | 2 +- gdb/valops.c | 2 +- gdb/value.c | 2 +- gdb/value.h | 10 +++++----- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/gdb/dwarf2/expr.c b/gdb/dwarf2/expr.c index 760c5c4b0d0..3f040e7b2d3 100644 --- a/gdb/dwarf2/expr.c +++ b/gdb/dwarf2/expr.c @@ -1005,7 +1005,7 @@ dwarf_expr_context::fetch_result (struct type *type, struct type *subobj_type, retval = value_at_lazy (subobj_type, address + subobj_offset); if (in_stack_memory) - retval->set_stack (1); + retval->set_stack (true); } break; diff --git a/gdb/frame-unwind.c b/gdb/frame-unwind.c index e5f8dc639e3..a3673dde77a 100644 --- a/gdb/frame-unwind.c +++ b/gdb/frame-unwind.c @@ -289,7 +289,7 @@ frame_unwind_got_memory (frame_info_ptr frame, int regnum, CORE_ADDR addr) struct gdbarch *gdbarch = frame_unwind_arch (frame); struct value *v = value_at_lazy (register_type (gdbarch, regnum), addr); - v->set_stack (1); + v->set_stack (true); return v; } diff --git a/gdb/valops.c b/gdb/valops.c index 90f7b8c5532..3a1b14c3d44 100644 --- a/gdb/valops.c +++ b/gdb/valops.c @@ -1041,7 +1041,7 @@ value_at_lazy (struct type *type, CORE_ADDR addr) void read_value_memory (struct value *val, LONGEST bit_offset, - int stack, CORE_ADDR memaddr, + bool stack, CORE_ADDR memaddr, gdb_byte *buffer, size_t length) { ULONGEST xfered_total = 0; diff --git a/gdb/value.c b/gdb/value.c index 855354f542f..6a8c12823c4 100644 --- a/gdb/value.c +++ b/gdb/value.c @@ -3743,7 +3743,7 @@ value::fetch_lazy_memory () gdb_assert (len >= 0); if (len > 0) - read_value_memory (this, 0, stack (), addr, + read_value_memory (this, false, stack (), addr, contents_all_raw ().data (), len); } diff --git a/gdb/value.h b/gdb/value.h index 41327ebe3b8..4cb6fac4104 100644 --- a/gdb/value.h +++ b/gdb/value.h @@ -135,7 +135,7 @@ struct value : m_modifiable (true), m_lazy (true), m_initialized (true), - m_stack (0), + m_stack (false), m_is_zero (false), m_in_history (false), m_type (type_), @@ -314,10 +314,10 @@ struct value void set_enclosing_type (struct type *new_type); - int stack () const + bool stack () const { return m_stack; } - void set_stack (int val) + void set_stack (bool val) { m_stack = val; } /* If this value is lval_computed, return its lval_funcs @@ -642,7 +642,7 @@ struct value /* If value is from the stack. If this is set, read_stack will be used instead of read_memory to enable extra caching. */ - unsigned int m_stack : 1; + bool m_stack : 1; /* True if this is a zero value, created by 'value::zero'; false otherwise. */ @@ -1000,7 +1000,7 @@ extern struct value *coerce_array (struct value *value); whether the memory is known to be stack memory. */ extern void read_value_memory (struct value *val, LONGEST bit_offset, - int stack, CORE_ADDR memaddr, + bool stack, CORE_ADDR memaddr, gdb_byte *buffer, size_t length); /* Cast SCALAR_VALUE to the element type of VECTOR_TYPE, then replicate -- 2.39.1