From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-761.bluehost.com (outbound-ss-761.bluehost.com [74.220.211.250]) by sourceware.org (Postfix) with ESMTPS id 2286F3858D1E for ; Tue, 14 Feb 2023 07:30:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2286F3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway8.mail.pro1.eigbox.com (Postfix) with ESMTP id EEFF21004BB9E for ; Tue, 14 Feb 2023 07:30:47 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id Rpm3pyxBIFh3zRpm3pOs3X; Tue, 14 Feb 2023 07:30:47 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=QpabYX+d c=1 sm=1 tr=0 ts=63eb38a7 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10:nop_charset_1 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=H2EY8jpounegQgt2ZJkA:9 a=QEXdDO2ut3YA:10:nop_charset_2 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=HkD2Zv3SAXHDvVRrPdxLhxAhEKNDodMKSl3X+zgc7oA=; b=vPospfG+8Npf2zPjirZShnUdit kZpYYLQTyaR3ZddpJ94kY+cyWVS0JpqK8hiKFdaADlLm2IwS7N2gQWYSsYJRLMfor1VC3L5krgyNz 9U6KgGHKMqBDLq0PwTzrG1AeA; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:48254 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pRpm3-000BP8-Ni; Tue, 14 Feb 2023 00:30:47 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [pushed] Fix build bug in ppc-linux-nat.c Date: Tue, 14 Feb 2023 00:30:34 -0700 Message-Id: <20230214073034.1992485-1-tom@tromey.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pRpm3-000BP8-Ni X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (localhost.localdomain) [75.166.130.93]:48254 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3027.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The buildbot pointed out that my value refactoring series introduced a bug in ppc-linux-nat.c: ../../binutils-gdb/gdb/ppc-linux-nat.c: In member function β€˜int ppc_linux_nat_target::num_memory_accesses(const std::vector >&)’: ../../binutils-gdb/gdb/ppc-linux-nat.c:2458:44: error: expected unqualified-id before β€˜->’ token 2458 | if (VALUE_LVAL (v) == not_lval || v->->deprecated_modifiable () == 0) I don't know how that happened, but I am checking in this patch which I think should fix it. It just removes the second "->". I can't readily test this, so perhaps there's another bug lurking after this one. --- gdb/ppc-linux-nat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/ppc-linux-nat.c b/gdb/ppc-linux-nat.c index e4fcce694cf..32c0177228a 100644 --- a/gdb/ppc-linux-nat.c +++ b/gdb/ppc-linux-nat.c @@ -2455,7 +2455,7 @@ ppc_linux_nat_target::num_memory_accesses (const std::vector struct value *v = iter.get (); /* Constants and values from the history are fine. */ - if (v->lval () == not_lval || v->->deprecated_modifiable () == 0) + if (v->lval () == not_lval || v->deprecated_modifiable () == 0) continue; else if (v->lval () == lval_memory) { -- 2.39.1