From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id B9C413858D33 for ; Tue, 14 Feb 2023 19:23:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B9C413858D33 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com Received: from smarchi-efficios.internal.efficios.com (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 696551E128; Tue, 14 Feb 2023 14:23:29 -0500 (EST) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH v2 2/3] gdb: add constructor to internalvar Date: Tue, 14 Feb 2023 14:23:26 -0500 Message-Id: <20230214192327.318301-2-simon.marchi@efficios.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230214192327.318301-1-simon.marchi@efficios.com> References: <20230214192327.318301-1-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3497.7 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_SOFTFAIL,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Add a constructor that takes the name as a parameter. Initialize the Change-Id: Ic4db0aba85f1da9f12f3eee0ac62c0e5ef0cfe88 --- gdb/value.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/gdb/value.c b/gdb/value.c index 936949f4a1f1..7fd11ba70db6 100644 --- a/gdb/value.c +++ b/gdb/value.c @@ -1829,14 +1829,18 @@ union internalvar_data struct internalvar { - struct internalvar *next; + internalvar (std::string name) + : name (std::move (name)) + {} + + struct internalvar *next = nullptr; std::string name; /* We support various different kinds of content of an internal variable. enum internalvar_kind specifies the kind, and union internalvar_data provides the data associated with this particular kind. */ - enum internalvar_kind kind; + enum internalvar_kind kind = INTERNALVAR_VOID; union internalvar_data u; }; @@ -1922,10 +1926,8 @@ complete_internalvar (completion_tracker &tracker, const char *name) struct internalvar * create_internalvar (const char *name) { - internalvar *var = new internalvar; + internalvar *var = new internalvar (name); - var->name = name; - var->kind = INTERNALVAR_VOID; var->next = internalvars; internalvars = var; return var; -- 2.39.1