From: Hui Li <lihui@loongson.cn>
To: gdb-patches@sourceware.org
Cc: Hui Li <lihui@loongson.cn>
Subject: [PATCH 1/2] gdb: LoongArch: Modify the result of the info reg command
Date: Thu, 16 Feb 2023 19:20:19 +0800 [thread overview]
Message-ID: <20230216112020.25610-2-lihui@loongson.cn> (raw)
In-Reply-To: <20230216112020.25610-1-lihui@loongson.cn>
The "info register" command should only display general registers,
but it shows the information of all registers in the current code,
add loongarch_register_reggroup_p() so that we can get the expected
result.
Signed-off-by: Hui Li <lihui@loongson.cn>
---
gdb/loongarch-tdep.c | 39 +++++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/gdb/loongarch-tdep.c b/gdb/loongarch-tdep.c
index 5f7a8a00ce7..67ea5494d90 100644
--- a/gdb/loongarch-tdep.c
+++ b/gdb/loongarch-tdep.c
@@ -24,6 +24,7 @@
#include "frame-unwind.h"
#include "gdbcore.h"
#include "loongarch-tdep.h"
+#include "reggroups.h"
#include "target.h"
#include "target-descriptions.h"
#include "trad-frame.h"
@@ -1433,6 +1434,43 @@ loongarch_find_default_target_description (const struct gdbarch_info info)
return loongarch_lookup_target_description (features);
}
+static int
+loongarch_register_reggroup_p (struct gdbarch *gdbarch, int regnum,
+ const struct reggroup *group)
+{
+ if (gdbarch_register_name (gdbarch, regnum) == NULL
+ || *gdbarch_register_name (gdbarch, regnum) == '\0')
+ return 0;
+
+ int raw_p = regnum < gdbarch_num_regs (gdbarch);
+
+ if (group == save_reggroup || group == restore_reggroup)
+ return raw_p;
+
+ if (group == all_reggroup)
+ return 1;
+
+ if (0 <= regnum && regnum <= LOONGARCH_BADV_REGNUM)
+ return group == general_reggroup;
+
+ /* Only ORIG_A0, PC, BADV in general_reggroup */
+ if (group == general_reggroup)
+ return 0;
+
+ if (LOONGARCH_FIRST_FP_REGNUM <= regnum && regnum <= LOONGARCH_FCSR_REGNUM)
+ return group == float_reggroup;
+
+ /* Only $fx / $fccx / $fcsr in float_reggroup */
+ if (group == float_reggroup)
+ return 0;
+
+ int ret = tdesc_register_in_reggroup_p (gdbarch, regnum, group);
+ if (ret != -1)
+ return ret;
+
+ return default_register_reggroup_p (gdbarch, regnum, group);
+}
+
/* Initialize the current architecture based on INFO */
static struct gdbarch *
@@ -1586,6 +1624,7 @@ loongarch_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
/* Hook in OS ABI-specific overrides, if they have been registered. */
gdbarch_init_osabi (info, gdbarch);
+ set_gdbarch_register_reggroup_p (gdbarch, loongarch_register_reggroup_p);
return gdbarch;
}
--
2.38.0
next prev parent reply other threads:[~2023-02-16 11:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 11:20 [PATCH 0/2] gdb: LoongArch: Modify " Hui Li
2023-02-16 11:20 ` Hui Li [this message]
2023-02-16 11:20 ` [PATCH 2/2] gdb: LoongArch: Support reg aliases in " Hui Li
2023-02-23 12:38 ` [PATCH 0/2] gdb: LoongArch: Modify the " Tiezhu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230216112020.25610-2-lihui@loongson.cn \
--to=lihui@loongson.cn \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).