public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Remove exception_catchpoint::resources_needed
@ 2023-02-16 17:26 Tom Tromey
  2023-03-06 15:09 ` Tom Tromey
  0 siblings, 1 reply; 2+ messages in thread
From: Tom Tromey @ 2023-02-16 17:26 UTC (permalink / raw)
  To: gdb-patches; +Cc: Tom Tromey

exception_catchpoint::resources_needed has a FIXME comment that I
think makes this method obsolete.  Also, I note that similar
catchpoints, for example Ada catchpoints, don't have this method.
This patch removes the method.  Regression tested on x86-64 Fedora 36.
---
 gdb/break-catch-throw.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/gdb/break-catch-throw.c b/gdb/break-catch-throw.c
index ab7899e2b9c..457446efbc6 100644
--- a/gdb/break-catch-throw.c
+++ b/gdb/break-catch-throw.c
@@ -94,13 +94,6 @@ struct exception_catchpoint : public code_breakpoint
   void check_status (struct bpstat *bs) override;
   struct bp_location *allocate_location () override;
 
-  /* FIXME this is temporary - until ordinary breakpoints have been
-     converted.  */
-  int resources_needed (const struct bp_location *) override
-  {
-    return 1;
-  }
-
   /* The kind of exception catchpoint.  */
 
   enum exception_event_kind kind;
-- 
2.39.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Remove exception_catchpoint::resources_needed
  2023-02-16 17:26 [PATCH] Remove exception_catchpoint::resources_needed Tom Tromey
@ 2023-03-06 15:09 ` Tom Tromey
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2023-03-06 15:09 UTC (permalink / raw)
  To: Tom Tromey via Gdb-patches; +Cc: Tom Tromey

>>>>> "Tom" == Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> writes:

Tom> exception_catchpoint::resources_needed has a FIXME comment that I
Tom> think makes this method obsolete.  Also, I note that similar
Tom> catchpoints, for example Ada catchpoints, don't have this method.
Tom> This patch removes the method.  Regression tested on x86-64 Fedora 36.

I'm checking this in.

Tom

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-03-06 15:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-16 17:26 [PATCH] Remove exception_catchpoint::resources_needed Tom Tromey
2023-03-06 15:09 ` Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).