From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@adacore.com>
Subject: [pushed] Rename parameter of create_ada_exception_catchpoint
Date: Thu, 16 Feb 2023 10:29:52 -0700 [thread overview]
Message-ID: <20230216172952.2240759-1-tromey@adacore.com> (raw)
create_ada_exception_catchpoint has a parameter named "disabled", but
both its callers and callees use it to mean "enabled". This is
confusing, so this patch renames the parameter.
---
gdb/ada-lang.c | 4 ++--
gdb/ada-lang.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index b5afba30b4f..eb81d737ca0 100644
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -12783,7 +12783,7 @@ create_ada_exception_catchpoint (struct gdbarch *gdbarch,
const std::string &excep_string,
const std::string &cond_string,
int tempflag,
- int disabled,
+ int enabled,
int from_tty)
{
std::string addr_string;
@@ -12791,7 +12791,7 @@ create_ada_exception_catchpoint (struct gdbarch *gdbarch,
std::unique_ptr<ada_catchpoint> c
(new ada_catchpoint (gdbarch, ex_kind, sal, addr_string.c_str (),
- tempflag, disabled, from_tty));
+ tempflag, enabled, from_tty));
c->excep_string = excep_string;
create_excep_cond_exprs (c.get (), ex_kind);
if (!cond_string.empty ())
diff --git a/gdb/ada-lang.h b/gdb/ada-lang.h
index 339c151798e..f5bb54c7d36 100644
--- a/gdb/ada-lang.h
+++ b/gdb/ada-lang.h
@@ -342,7 +342,7 @@ extern const char *ada_main_name ();
extern void create_ada_exception_catchpoint
(struct gdbarch *gdbarch, enum ada_exception_catchpoint_kind ex_kind,
const std::string &excep_string, const std::string &cond_string, int tempflag,
- int disabled, int from_tty);
+ int enabled, int from_tty);
/* Return true if BP is an Ada catchpoint. */
--
2.39.1
reply other threads:[~2023-02-16 17:30 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230216172952.2240759-1-tromey@adacore.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).