From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@adacore.com>
Subject: [pushed] Remove two unnecessary returns in ada-lang.c
Date: Fri, 17 Feb 2023 10:25:32 -0700 [thread overview]
Message-ID: <20230217172532.2369102-1-tromey@adacore.com> (raw)
I found a couple of spots in ada-lang.c where a return follows a call
to error. These are unnecessary because error never returns.
---
gdb/ada-lang.c | 14 ++++----------
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index eb81d737ca0..75c5f5ebd6e 100644
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -11731,11 +11731,8 @@ ada_has_this_exception_support (const struct exception_support_info *einfo)
/* Make sure that the symbol we found corresponds to a function. */
if (sym->aclass () != LOC_BLOCK)
- {
- error (_("Symbol \"%s\" is not a function (class = %d)"),
- sym->linkage_name (), sym->aclass ());
- return 0;
- }
+ error (_("Symbol \"%s\" is not a function (class = %d)"),
+ sym->linkage_name (), sym->aclass ());
sym = standard_lookup (einfo->catch_handlers_sym, NULL, VAR_DOMAIN);
if (sym == NULL)
@@ -11754,11 +11751,8 @@ ada_has_this_exception_support (const struct exception_support_info *einfo)
/* Make sure that the symbol we found corresponds to a function. */
if (sym->aclass () != LOC_BLOCK)
- {
- error (_("Symbol \"%s\" is not a function (class = %d)"),
- sym->linkage_name (), sym->aclass ());
- return 0;
- }
+ error (_("Symbol \"%s\" is not a function (class = %d)"),
+ sym->linkage_name (), sym->aclass ());
return 1;
}
--
2.39.1
reply other threads:[~2023-02-17 17:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230217172532.2369102-1-tromey@adacore.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).