From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 9EDE83858D38 for ; Mon, 20 Feb 2023 17:01:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9EDE83858D38 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com Received: from smarchi-efficios.internal.efficios.com (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id E4EAA1E128; Mon, 20 Feb 2023 12:01:35 -0500 (EST) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [pushed] gdb: revert one erroneous bool-ification change Date: Mon, 20 Feb 2023 12:01:34 -0500 Message-Id: <20230220170134.15548-1-simon.marchi@efficios.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3497.6 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_SOFTFAIL,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Commit 42c13555ff88 ("Change value::m_stack to bool") erroneously changed a `0` to `false` in this call to read_value_memory. This parameter is `LONGEST bit_offset`, it should stay `0`. Change-Id: I128df6834cf8055ec6a7051e237e379978d3d651 --- gdb/value.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/value.c b/gdb/value.c index e52d1d77b48f..d2c2a2d7859b 100644 --- a/gdb/value.c +++ b/gdb/value.c @@ -3749,7 +3749,7 @@ value::fetch_lazy_memory () gdb_assert (len >= 0); if (len > 0) - read_value_memory (this, false, stack (), addr, + read_value_memory (this, 0, stack (), addr, contents_all_raw ().data (), len); } -- 2.39.1