From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 67DB93858D33 for ; Wed, 22 Feb 2023 23:54:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 67DB93858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677110058; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4JDUPwg4jQgasM39NSU9dfARcBamxUk291Oa3jQ7WGM=; b=YmXlV1y7T09OEdoL034nMTWuEBYEomo00gGk4yHgcMojZThWlRn2gKbamswrOOM8qqnnoy BjDN5vPqsk+lqjtzI9LT3dXF6M40fb92XjIuxjVcWYXllYaNe6iQmA+4XTM5O1AO77CT6A iEgfX8NykO9mDzfgMTq7XQ2YJbjHsCk= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-626-SP9re7FtPOm6YCPt-WuV2Q-1; Wed, 22 Feb 2023 18:54:14 -0500 X-MC-Unique: SP9re7FtPOm6YCPt-WuV2Q-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A01DD3C0D183; Wed, 22 Feb 2023 23:54:14 +0000 (UTC) Received: from f37-zws-nv (unknown [10.2.16.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 459182166B29; Wed, 22 Feb 2023 23:54:14 +0000 (UTC) Date: Wed, 22 Feb 2023 16:54:07 -0700 From: Kevin Buettner To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [PATCH] Remove 'eval' from gdb_breakpoint Message-ID: <20230222165407.1da39ba6@f37-zws-nv> In-Reply-To: <20230222222242.65558-1-tromey@adacore.com> References: <20230222222242.65558-1-tromey@adacore.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 22 Feb 2023 15:22:42 -0700 Tom Tromey via Gdb-patches wrote: > Now that Tcl has the {*} operator, we can remove the use of eval from > gdb_breakpoint. Tested on x86-64 Fedora 36. I didn't know about Tcl's {*} operator, but found an explanation here: https://stackoverflow.com/questions/5124185/what-does-do-in-tcl Anyway, LGTM. Kevin