From: Simon Marchi <simon.marchi@efficios.com>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: [PATCH 0/9] Add typing annotations to gdbarch*.py and make-target-delegates.py
Date: Thu, 23 Feb 2023 17:18:21 -0500 [thread overview]
Message-ID: <20230223221830.499934-1-simon.marchi@efficios.com> (raw)
While investigating something related to a gdbarch method, I was trying
to understand the purpose of the "invalid" Function parameter. It is
sometimes passed a boolean and sometimes passed a string. This is
indeed described in the comment at the top of gdbarch-components.py, but
I then thought that if we used type annotations, it would make it clear
that it's intended. Also, I find type annotations (when paired with a
checker such as pyright or pylance) really handy to avoid all kinds of
mistake. So I got a bit carried away, and this series is the result.
Simon Marchi (9):
gdb: remove invalid / dead code from gdbarch.py
gdb: reformat Python files with black 23.1.0
gdb: gdbarch.py: spell out parameters of _Component.__init__
gdb: pyproject.toml: set pyright typeCheckingMode = "strict"
gdb: split gdbarch component types to gdbarch_types.py
gdb: gdbarch*.py, copyright.py: add type annotations
gdb: make-target-delegates.py: make one string raw
gdb: make-target-delegates.py: add Entry type
gdb: make-target-delegates.py: add type annotations
gdb/gdbarch.py | 161 +--------------
...ch-components.py => gdbarch_components.py} | 8 +-
gdb/gdbarch_types.py | 189 ++++++++++++++++++
gdb/gdbcopyright.py | 2 +-
gdb/make-target-delegates.py | 104 +++++++---
gdb/pyproject.toml | 3 +
gdb/python/lib/gdb/FrameDecorator.py | 1 -
gdb/python/lib/gdb/command/frame_filters.py | 1 +
gdb/python/lib/gdb/dap/server.py | 2 +-
gdb/python/lib/gdb/printing.py | 2 +-
.../gdb.multi/multi-target-info-inferiors.py | 1 +
gdb/testsuite/gdb.perf/backtrace.py | 1 -
.../gdb.python/py-framefilter-addr.py | 1 +
gdb/testsuite/gdb.python/py-framefilter.py | 1 +
gdb/testsuite/gdb.python/py-inferior-leak.py | 2 +
gdb/testsuite/gdb.python/py-prettyprint.py | 1 +
gdb/testsuite/gdb.python/py-recurse-unwind.py | 5 -
gdb/testsuite/gdb.python/py-send-packet.py | 1 +
gdb/testsuite/gdb.python/tui-window.py | 1 +
19 files changed, 290 insertions(+), 197 deletions(-)
rename gdb/{gdbarch-components.py => gdbarch_components.py} (99%)
create mode 100755 gdb/gdbarch_types.py
--
2.39.2
next reply other threads:[~2023-02-23 22:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 22:18 Simon Marchi [this message]
2023-02-23 22:18 ` [PATCH 1/9] gdb: remove invalid / dead code from gdbarch.py Simon Marchi
2023-02-23 22:18 ` [PATCH 2/9] gdb: reformat Python files with black 23.1.0 Simon Marchi
2023-02-23 22:18 ` [PATCH 3/9] gdb: gdbarch.py: spell out parameters of _Component.__init__ Simon Marchi
2023-02-24 19:51 ` Tom Tromey
2023-02-24 20:31 ` Simon Marchi
2023-02-24 22:07 ` Tom Tromey
2023-02-23 22:18 ` [PATCH 4/9] gdb: pyproject.toml: set pyright typeCheckingMode = "strict" Simon Marchi
2023-02-23 22:18 ` [PATCH 5/9] gdb: split gdbarch component types to gdbarch_types.py Simon Marchi
2023-02-23 22:18 ` [PATCH 6/9] gdb: gdbarch*.py, copyright.py: add type annotations Simon Marchi
2023-02-23 22:18 ` [PATCH 7/9] gdb: make-target-delegates.py: make one string raw Simon Marchi
2023-02-23 22:18 ` [PATCH 8/9] gdb: make-target-delegates.py: add Entry type Simon Marchi
2023-02-23 22:18 ` [PATCH 9/9] gdb: make-target-delegates.py: add type annotations Simon Marchi
2023-02-24 19:54 ` [PATCH 0/9] Add typing annotations to gdbarch*.py and make-target-delegates.py Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230223221830.499934-1-simon.marchi@efficios.com \
--to=simon.marchi@efficios.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).