From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by sourceware.org (Postfix) with ESMTPS id B78B93857C45 for ; Fri, 24 Feb 2023 20:28:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B78B93857C45 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id 32F671003EF9D for ; Fri, 24 Feb 2023 20:28:35 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id VegFpj8lsNX2aVegFpSKkS; Fri, 24 Feb 2023 20:28:35 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=NMAQR22g c=1 sm=1 tr=0 ts=63f91df3 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10:nop_charset_1 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=zstS-IiYAAAA:8 a=QoAGnRKEce7iof8VkmwA:9 a=QEXdDO2ut3YA:10:nop_charset_2 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:Content-Transfer-Encoding:Content-Type:MIME-Version: Message-Id:Date:Subject:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=CTSCmUrb4PkTJA3mLgLKsuUr8UF6r0AOeVYG1AUa788=; b=rMui2oMNv73OvXBsZeemD3x6z2 hlEO70a+dVuy9sLNhdgm1wcwcuxO2R9VzqVJ88YlZpQ2awm2uDExFJ6+Lz1K2ml3cUId3kq7tcXAe PfGO9RPCpBfS5bwPun5rppIw/; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:37332 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pVegF-002w7s-00 for gdb-patches@sourceware.org; Fri, 24 Feb 2023 13:28:35 -0700 From: Tom Tromey Subject: [PATCH 0/4] More uses of require Date: Fri, 24 Feb 2023 13:28:27 -0700 Message-Id: <20230224-submit-require-fixes-v1-0-7cbcbbf613c9@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAOsd+WMC/x3LwQ6CMBCE4Vche3aTWg0pvorx0JYB9kDVXTAmh He3ePxn8m1kUIHRrdlI8RGTZ6lxPjWUp1hGsPS1yTt/cd5f2dY0y8KK9yoKHuQL4zZkhK6HCwl UaYoGThpLng48R1ugx/FS/EVd7499/wH+KCy9fwAAAA== To: gdb-patches@sourceware.org X-Mailer: b4 0.12.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pVegF-002w7s-00 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net ([192.168.0.21]) [75.166.130.93]:37332 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3020.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I found some more places that can use 'require'. Before this series, some spots used "untested", some used "verbose", and some silently returned. I think it's better for the tests to try to be consistent in this sort of thing. Tom --- Tom Tromey (4): Use require with target_info Use require with gdb_skip_stdio_test More uses of require with istarget Use require with test_compiler_info gdb/testsuite/gdb.base/a2-run.exp | 4 +--- gdb/testsuite/gdb.base/args.exp | 4 +--- gdb/testsuite/gdb.base/bp-cmds-continue-ctrl-c.exp | 10 ++-------- gdb/testsuite/gdb.base/branch-to-self.exp | 5 +---- gdb/testsuite/gdb.base/call-ar-st.exp | 5 +---- gdb/testsuite/gdb.base/call-rt-st.exp | 11 +++-------- gdb/testsuite/gdb.base/call-sc.exp | 5 +---- gdb/testsuite/gdb.base/call-signal-resume.exp | 16 +++++----------- gdb/testsuite/gdb.base/call-strs.exp | 5 +---- gdb/testsuite/gdb.base/callexit.exp | 5 +---- gdb/testsuite/gdb.base/callfuncs.exp | 5 +---- gdb/testsuite/gdb.base/cast-call.exp | 5 +---- gdb/testsuite/gdb.base/catch-gdb-caused-signals.exp | 5 +---- gdb/testsuite/gdb.base/catch-signal-fork.exp | 5 +---- gdb/testsuite/gdb.base/catch-signal-siginfo-cond.exp | 5 +---- gdb/testsuite/gdb.base/catch-signal.exp | 5 +---- gdb/testsuite/gdb.base/checkpoint.exp | 4 +--- gdb/testsuite/gdb.base/exitsignal.exp | 5 +---- gdb/testsuite/gdb.base/fileio.exp | 5 +---- gdb/testsuite/gdb.base/foll-exec-mode.exp | 4 +--- gdb/testsuite/gdb.base/foll-exec.exp | 4 +--- gdb/testsuite/gdb.base/huge.exp | 4 +--- gdb/testsuite/gdb.base/infcall-input.exp | 5 +---- gdb/testsuite/gdb.base/inferior-args.exp | 5 +---- gdb/testsuite/gdb.base/inferior-died.exp | 5 +---- gdb/testsuite/gdb.base/interrupt-daemon-attach.exp | 10 ++-------- gdb/testsuite/gdb.base/interrupt.exp | 10 ++-------- gdb/testsuite/gdb.base/jit-reader-exec.exp | 4 +--- gdb/testsuite/gdb.base/kill-after-signal.exp | 5 +---- gdb/testsuite/gdb.base/long-inferior-output.exp | 5 +---- gdb/testsuite/gdb.base/long_long.exp | 4 +--- gdb/testsuite/gdb.base/multi-forks.exp | 4 +--- gdb/testsuite/gdb.base/paginate-after-ctrl-c-running.exp | 5 +---- gdb/testsuite/gdb.base/pie-execl.exp | 4 +--- gdb/testsuite/gdb.base/random-signal.exp | 10 ++-------- gdb/testsuite/gdb.base/relativedebug.exp | 5 +---- gdb/testsuite/gdb.base/savedregs.exp | 5 +---- gdb/testsuite/gdb.base/sigall.exp | 5 +---- gdb/testsuite/gdb.base/sigaltstack.exp | 5 +---- gdb/testsuite/gdb.base/sigbpt.exp | 5 +---- gdb/testsuite/gdb.base/sigchld.exp | 5 +---- gdb/testsuite/gdb.base/siginfo-addr.exp | 5 +---- gdb/testsuite/gdb.base/siginfo-infcall.exp | 5 +---- gdb/testsuite/gdb.base/siginfo-obj.exp | 5 +---- gdb/testsuite/gdb.base/siginfo-thread.exp | 5 +---- gdb/testsuite/gdb.base/siginfo.exp | 5 +---- gdb/testsuite/gdb.base/signals.exp | 5 +---- gdb/testsuite/gdb.base/signest.exp | 5 +---- gdb/testsuite/gdb.base/signull.exp | 5 +---- gdb/testsuite/gdb.base/sigrepeat.exp | 5 +---- gdb/testsuite/gdb.base/sigstep.exp | 5 +---- gdb/testsuite/gdb.base/sigwinch-notty.exp | 5 +---- gdb/testsuite/gdb.base/step-indirect-call-thunk.exp | 4 +--- gdb/testsuite/gdb.base/structs.exp | 5 +---- gdb/testsuite/gdb.base/unwindonsignal.exp | 10 ++-------- gdb/testsuite/gdb.base/vla-struct-fields.exp | 5 +---- gdb/testsuite/gdb.base/watch-cond-infcall.exp | 5 +---- gdb/testsuite/gdb.cp/gdb2495.exp | 10 ++-------- gdb/testsuite/gdb.fortran/array-slices.exp | 4 +--- gdb/testsuite/gdb.fortran/lbound-ubound.exp | 8 +++----- gdb/testsuite/gdb.gdb/python-helper.exp | 5 +---- gdb/testsuite/gdb.mi/mi-syn-frame.exp | 5 +---- gdb/testsuite/gdb.mi/mi-threads-interrupt.exp | 5 +---- gdb/testsuite/gdb.reverse/sigall-precsave.exp | 5 +---- gdb/testsuite/gdb.reverse/sigall-reverse.exp | 5 +---- gdb/testsuite/gdb.server/reconnect-ctrl-c.exp | 5 +---- gdb/testsuite/gdb.threads/check-libthread-db.exp | 3 ++- gdb/testsuite/gdb.threads/continue-pending-status.exp | 5 +---- gdb/testsuite/gdb.threads/hand-call-in-threads.exp | 11 ++++------- gdb/testsuite/gdb.threads/interrupted-hand-call.exp | 11 ++++------- gdb/testsuite/gdb.threads/leader-exit.exp | 5 +---- gdb/testsuite/gdb.threads/manythreads.exp | 5 +---- gdb/testsuite/gdb.threads/multiple-step-overs.exp | 5 +---- gdb/testsuite/gdb.threads/names.exp | 4 +--- gdb/testsuite/gdb.threads/non-stop-fair-events.exp | 5 +---- gdb/testsuite/gdb.threads/pthreads.exp | 5 +---- gdb/testsuite/gdb.threads/schedlock.exp | 5 +---- .../gdb.threads/signal-command-handle-nopass.exp | 5 +---- .../signal-command-multiple-signals-pending.exp | 5 +---- .../gdb.threads/signal-delivered-right-thread.exp | 5 +---- gdb/testsuite/gdb.threads/signal-sigtrap.exp | 5 +---- .../signal-while-stepping-over-bp-other-thread.exp | 5 +---- gdb/testsuite/gdb.threads/sigthread.exp | 9 +++------ gdb/testsuite/gdb.threads/thread-unwindonsignal.exp | 11 ++++------- gdb/testsuite/gdb.trace/signal.exp | 5 +---- gdb/testsuite/gdb.tui/completion.exp | 4 +--- 86 files changed, 112 insertions(+), 374 deletions(-) --- base-commit: 1293ecd838c82e86f6c81d4518f5c662f8eaa0b9 change-id: 20230224-submit-require-fixes-68ce89de08be Best regards, -- Tom Tromey