public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 2/4] Use require with gdb_skip_stdio_test
Date: Fri, 24 Feb 2023 13:28:29 -0700	[thread overview]
Message-ID: <20230224-submit-require-fixes-v1-2-7cbcbbf613c9@tromey.com> (raw)
In-Reply-To: <20230224-submit-require-fixes-v1-0-7cbcbbf613c9@tromey.com>

One use of gdb_skip_stdio_test can use 'require'.
---
 gdb/testsuite/gdb.base/a2-run.exp | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/gdb/testsuite/gdb.base/a2-run.exp b/gdb/testsuite/gdb.base/a2-run.exp
index d5d4d9ef19e..08f6599c84a 100644
--- a/gdb/testsuite/gdb.base/a2-run.exp
+++ b/gdb/testsuite/gdb.base/a2-run.exp
@@ -16,9 +16,7 @@
 # This file was written by Rob Savoye. (rob@cygnus.com)
 
 # Can't do this test without stdio support.
-if [gdb_skip_stdio_test "a2run.exp"] {
-    return
-}
+require {!gdb_skip_stdio_test "a2run.exp"}
 
 #
 # test running programs

-- 
2.39.1


  parent reply	other threads:[~2023-02-24 20:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-24 20:28 [PATCH 0/4] More uses of require Tom Tromey
2023-02-24 20:28 ` [PATCH 1/4] Use require with target_info Tom Tromey
2023-02-24 20:28 ` Tom Tromey [this message]
2023-02-24 20:28 ` [PATCH 3/4] More uses of require with istarget Tom Tromey
2023-02-24 20:28 ` [PATCH 4/4] Use require with test_compiler_info Tom Tromey
2023-03-10 14:56 ` [PATCH 0/4] More uses of require Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230224-submit-require-fixes-v1-2-7cbcbbf613c9@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).