From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@adacore.com>
Subject: [PATCH 4/8] Add value_as_mpz and value_from_mpz
Date: Fri, 3 Mar 2023 14:12:03 -0700 [thread overview]
Message-ID: <20230303211207.1053037-5-tromey@adacore.com> (raw)
In-Reply-To: <20230303211207.1053037-1-tromey@adacore.com>
This adds the two new functions, value_as_mpz and value_from_mpz,
useful for manipulation values via gdb_mpz.
---
gdb/value.c | 106 ++++++++++++++++++++++++++++++++++++++++++++++++++++
gdb/value.h | 7 ++++
2 files changed, 113 insertions(+)
diff --git a/gdb/value.c b/gdb/value.c
index e9afa89c243..19da9e1a00b 100644
--- a/gdb/value.c
+++ b/gdb/value.c
@@ -2551,6 +2551,76 @@ value_as_long (struct value *val)
return unpack_long (val->type (), val->contents ().data ());
}
+/* See value.h. */
+
+gdb_mpz
+value_as_mpz (struct value *val)
+{
+ val = coerce_array (val);
+ struct type *type = check_typedef (val->type ());
+
+ switch (type->code ())
+ {
+ case TYPE_CODE_ENUM:
+ case TYPE_CODE_BOOL:
+ case TYPE_CODE_INT:
+ case TYPE_CODE_CHAR:
+ case TYPE_CODE_RANGE:
+ break;
+
+ default:
+ return gdb_mpz (value_as_long (val));
+ }
+
+ gdb_mpz result;
+
+ gdb::array_view<const gdb_byte> valbytes = val->contents ();
+ enum bfd_endian byte_order = type_byte_order (type);
+
+ /* Handle integers that are either not a multiple of the word size,
+ or that are stored at some bit offset. */
+ unsigned bit_off = 0, bit_size = 0;
+ if (type->bit_size_differs_p ())
+ {
+ bit_size = type->bit_size ();
+ if (bit_size == 0)
+ {
+ /* We can just handle this immediately. */
+ return result;
+ }
+
+ bit_off = type->bit_offset ();
+
+ unsigned n_bytes = ((bit_off % 8) + bit_size + 7) / 8;
+ valbytes = valbytes.slice (bit_off / 8, n_bytes);
+
+ if (byte_order == BFD_ENDIAN_BIG)
+ bit_off = (n_bytes * 8 - bit_off % 8 - bit_size);
+ else
+ bit_off %= 8;
+ }
+
+ result.read (val->contents (), byte_order, type->is_unsigned ());
+
+ /* Shift off any low bits, if needed. */
+ if (bit_off != 0)
+ result >>= bit_off;
+
+ /* Mask off any high bits, if needed. */
+ if (bit_size)
+ result.mask (bit_size);
+
+ /* Now handle any range bias. */
+ if (type->code () == TYPE_CODE_RANGE && type->bounds ()->bias != 0)
+ {
+ /* Unfortunately we have to box here, because LONGEST is
+ probably wider than long. */
+ result += gdb_mpz (type->bounds ()->bias);
+ }
+
+ return result;
+}
+
/* Extract a value as a C pointer. Does not deallocate the value.
Note that val's type may not actually be a pointer; value_as_long
handles all the cases. */
@@ -3378,6 +3448,42 @@ value_from_ulongest (struct type *type, ULONGEST num)
return val;
}
+/* See value.h. */
+
+struct value *
+value_from_mpz (struct type *type, const gdb_mpz &v)
+{
+ struct type *real_type = check_typedef (type);
+
+ const gdb_mpz *val = &v;
+ gdb_mpz storage;
+ if (real_type->code () == TYPE_CODE_RANGE && type->bounds ()->bias != 0)
+ {
+ storage = *val;
+ val = &storage;
+ storage -= type->bounds ()->bias;
+ }
+
+ if (type->bit_size_differs_p ())
+ {
+ unsigned bit_off = type->bit_offset ();
+ unsigned bit_size = type->bit_size ();
+
+ if (val != &storage)
+ {
+ storage = *val;
+ val = &storage;
+ }
+
+ storage.mask ((ULONGEST) 1 << bit_size);
+ storage <<= bit_off;
+ }
+
+ struct value *result = value::allocate (type);
+ val->truncate (result->contents_raw (), type_byte_order (type),
+ type->is_unsigned ());
+ return result;
+}
/* Create a value representing a pointer of type TYPE to the address
ADDR. */
diff --git a/gdb/value.h b/gdb/value.h
index d83c4ab3674..1b4eff22f37 100644
--- a/gdb/value.h
+++ b/gdb/value.h
@@ -1029,6 +1029,11 @@ extern bool is_floating_value (struct value *val);
extern LONGEST value_as_long (struct value *val);
extern CORE_ADDR value_as_address (struct value *val);
+/* Extract the value from VAL as a MPZ. This coerces arrays and
+ handles various integer-like types as well. */
+
+extern gdb_mpz value_as_mpz (struct value *val);
+
extern LONGEST unpack_long (struct type *type, const gdb_byte *valaddr);
extern CORE_ADDR unpack_pointer (struct type *type, const gdb_byte *valaddr);
@@ -1075,6 +1080,8 @@ extern struct value *value_from_history_ref (const char *, const char **);
extern struct value *value_from_component (struct value *, struct type *,
LONGEST);
+/* Convert the value V into a newly allocated value. */
+extern struct value *value_from_mpz (struct type *type, const gdb_mpz &v);
extern struct value *value_at (struct type *type, CORE_ADDR addr);
extern struct value *value_at_lazy (struct type *type, CORE_ADDR addr);
--
2.39.1
next prev parent reply other threads:[~2023-03-03 21:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 21:11 [PATCH 0/8] Arithmetic for 128-bit types Tom Tromey
2023-03-03 21:12 ` [PATCH 1/8] Add many operators to gdb_mpz Tom Tromey
2023-03-07 13:38 ` Alexandra Petlanova Hajkova
2023-03-03 21:12 ` [PATCH 2/8] Avoid a copy in gdb_mpz::safe_export Tom Tromey
2023-03-03 21:12 ` [PATCH 3/8] Add truncation mode to gdb_mpz Tom Tromey
2023-03-03 21:12 ` Tom Tromey [this message]
2023-03-08 10:47 ` [PATCH 4/8] Add value_as_mpz and value_from_mpz Lancelot SIX
2023-03-08 15:48 ` Tom Tromey
2023-03-03 21:12 ` [PATCH 5/8] Simplify binop_promote Tom Tromey
2023-03-03 21:12 ` [PATCH 6/8] Use value_true in value_equal and value_less Tom Tromey
2023-03-03 21:12 ` [PATCH 7/8] Use gdb_gmp for scalar arithmetic Tom Tromey
2023-03-03 21:12 ` [PATCH 8/8] Fix 128-bit integer bug in Ada Tom Tromey
2023-03-04 7:04 ` [PATCH 0/8] Arithmetic for 128-bit types Eli Zaretskii
2023-03-08 16:17 ` Tom Tromey
2023-03-27 14:20 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230303211207.1053037-5-tromey@adacore.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).