From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 9BAEA3858D3C for ; Tue, 7 Mar 2023 14:45:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9BAEA3858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C6ED621A1E for ; Tue, 7 Mar 2023 14:45:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1678200357; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=oUbcJM48KvFk0yQ8tTfYq9Ge6PVMkHthsiY2gx0yWX8=; b=MeO5I86900Ah14e6ZgpW3cS3G/SK3Vw5CbYIs+KIQMDl38HgGZpvsjtkbB0+eUhf48ksjv xNoPUKJonHODmg//3yU7tG1/PIhZJoMJRXSybzF9kVJz5cS6fXnlyLxC71OgfaMpeoXsKu 4yLQFEyvRtMfsDkqo5jD8BOfRb0piOE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1678200357; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=oUbcJM48KvFk0yQ8tTfYq9Ge6PVMkHthsiY2gx0yWX8=; b=8VJ2i0ey9D9IxwsiOoX8LLi02DNgqiaJXrWqUEdD6TnDeNtHbelIq34BGz+4SW18EZcxut SJeO9LAaojE9i3BQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AF2801341F for ; Tue, 7 Mar 2023 14:45:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8JBcKSVOB2QpCQAAMHmgww (envelope-from ) for ; Tue, 07 Mar 2023 14:45:57 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [pushed 1/2] [gdb/testsuite] Use shlib gdb_compile option in gdb.base/skip-solib.exp Date: Tue, 7 Mar 2023 15:46:02 +0100 Message-Id: <20230307144603.5152-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: In test-case gdb.base/skip-solib.exp the linking against a shared library is done manually: ... if {[gdb_compile "${binfile_main}.o" "${binfile_main}" executable \ [list debug "additional_flags=-L$testobjdir" \ "additional_flags=-l${test}" \ "ldflags=-Wl,-rpath=$testobjdir"]] != ""} { ... Instead, use the shlib gdb_compile option such that we simply have: ... [list debug shlib=$binfile_lib]] != ""} { ... Tested on x86_64-linux. --- gdb/testsuite/gdb.base/skip-solib.exp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/gdb/testsuite/gdb.base/skip-solib.exp b/gdb/testsuite/gdb.base/skip-solib.exp index 3cdb455bb59..f01196c3fed 100644 --- a/gdb/testsuite/gdb.base/skip-solib.exp +++ b/gdb/testsuite/gdb.base/skip-solib.exp @@ -51,9 +51,7 @@ if {[gdb_compile "${srcdir}/${subdir}/${srcfile_main}" "${binfile_main}.o" \ set testobjdir [standard_output_file {}] if {[gdb_compile "${binfile_main}.o" "${binfile_main}" executable \ - [list debug "additional_flags=-L$testobjdir" \ - "additional_flags=-l${test}" \ - "ldflags=-Wl,-rpath=$testobjdir"]] != ""} { + [list debug shlib=$binfile_lib]] != ""} { return -1 } base-commit: dfe30a41c8c1237f70a9cc31cc8cc90f1c1a46f6 -- 2.35.3