From: Kevin Buettner <kevinb@redhat.com>
To: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH] Remove dead code from scalar_binop
Date: Fri, 10 Mar 2023 16:38:29 -0700 [thread overview]
Message-ID: <20230310163829.076728ac@f37-zws-nv> (raw)
In-Reply-To: <20230301212708.4030388-1-tromey@adacore.com>
On Wed, 1 Mar 2023 14:27:08 -0700
Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> wrote:
> scalar_binop has code for "&&" and "||", but I think this code can't
> currently be run -- and, furthermore, it doesn't make sense to have
> this code here, as the point of these operators is to short-circuit
> evaluation.
Agreed, on both points. (Though it took me a while to convince myself
that it couldn't currently be run.)
Approved-by: Kevin Buettner <kevinb@redhat.com>
prev parent reply other threads:[~2023-03-10 23:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 21:27 Tom Tromey
2023-03-10 23:38 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230310163829.076728ac@f37-zws-nv \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).