From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 07B263858D1E for ; Mon, 13 Mar 2023 16:20:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 07B263858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3494E1FE0E for ; Mon, 13 Mar 2023 16:20:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1678724452; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MODDssHFE+JknLKBlngvBSt5smovRsFC8foCAWK1r0k=; b=TjoXtVWvOg+h85nYmqOZDZayYOwncoSt1xNuVQT8Fevqk4iP3gQ91Mhsg2AngQFCMs2PZK OagBwjf7Gl1f/Vu11EqKNQEHNIwPsKDJ6vv9apsRv3sckIEYQ38l0yIXImJ3MdGk/f+60W FPQT5sfBousjJ27pInyWWvR7qWUzD7I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1678724452; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MODDssHFE+JknLKBlngvBSt5smovRsFC8foCAWK1r0k=; b=lidcj3awnYS8/2WOOAqgXfb934mWFvMPjgs1lP8r3KQBMhLa9xQh5GyJ20mz7WQabsdTo8 zGrJMoyu6Zd/eRBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2145613517 for ; Mon, 13 Mar 2023 16:20:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id uIABB2RND2QbDAAAMHmgww (envelope-from ) for ; Mon, 13 Mar 2023 16:20:52 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [pushed 4/8] [gdb/testsuite] Fix gdb.tui/tui-nl-filtered-output.exp for remote host Date: Mon, 13 Mar 2023 17:20:47 +0100 Message-Id: <20230313162051.488-5-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230313162051.488-1-tdevries@suse.de> References: <20230313162051.488-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: When running test-case gdb.tui/tui-nl-filtered-output.exp with host board local-remote-host-notty and target board native-gdbserver, I get: ... FAIL: gdb.tui/tui-nl-filtered-output.exp: check printf output ... The problem is that Term::enter_tui is returning 0, but the test-case doesn't check for this, and consequently runs unsupported tests. Fix this by adding the missing check. Tested on x86_64-linux. --- gdb/testsuite/gdb.tui/tui-nl-filtered-output.exp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.tui/tui-nl-filtered-output.exp b/gdb/testsuite/gdb.tui/tui-nl-filtered-output.exp index 5b1d6b7d9ba..8f85ae7ce49 100644 --- a/gdb/testsuite/gdb.tui/tui-nl-filtered-output.exp +++ b/gdb/testsuite/gdb.tui/tui-nl-filtered-output.exp @@ -36,7 +36,10 @@ tuiterm_env # Setup and enter TUI mode. Term::clean_restart 24 80 -Term::enter_tui +if {![Term::enter_tui]} { + unsupported "TUI not supported" + return +} # Send the command, and check the output is correctly split over # multiple lines. -- 2.35.3