From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 1FE093858414 for ; Mon, 13 Mar 2023 16:20:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1FE093858414 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4F6801FE15 for ; Mon, 13 Mar 2023 16:20:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1678724452; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DNkl7YnUvNE0d2JGvWijaB2qPUUbSTRe41i9AMxQIjY=; b=CfD+XXuamsNp+VtKrebnOGwS9G6KfZODfpYTl+vGJivVAZDSiig4kffP2vYnH4SV6p5vzR +TK4iBNOJB4s1/CCNwvUMCP8vZZPtICpg31YhEj32x0Cr1D5JGnC2hRKQEU3te6BWnUFCD mOKfgpguOG+ge6fdkn8HeLnnD9k23DU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1678724452; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DNkl7YnUvNE0d2JGvWijaB2qPUUbSTRe41i9AMxQIjY=; b=3Rv7M3+r/JhS6jF3+HDq9LV0WeVr/cbT2QHyXcZtzGZHtU1AKR6xC1n7tduoDtq4ewa020 O8OW64KPHhoSGBBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3C2CA13517 for ; Mon, 13 Mar 2023 16:20:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id UFItDWRND2QbDAAAMHmgww (envelope-from ) for ; Mon, 13 Mar 2023 16:20:52 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [pushed 5/8] [gdb/testsuite] Fix gdb.tui/tui-layout.exp for remote host Date: Mon, 13 Mar 2023 17:20:48 +0100 Message-Id: <20230313162051.488-6-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230313162051.488-1-tdevries@suse.de> References: <20230313162051.488-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: When running test-case gdb.tui/tui-layout.exp with host board local-remote-host-notty and target board native-gdbserver, I get: ... FAIL: gdb.tui/tui-layout.exp: terminal=dumb: execution=false: layout=asm: \ layout asm (timeout) ... The problem is that the test-case expects that the default "setenv TERM dumb" has effect, which is not the case for remote host. Fix this by skipping the test for remote host. Tested on x86_64-linux. --- gdb/testsuite/gdb.tui/tui-layout.exp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gdb/testsuite/gdb.tui/tui-layout.exp b/gdb/testsuite/gdb.tui/tui-layout.exp index c7fdb1b0c0a..13823387e72 100644 --- a/gdb/testsuite/gdb.tui/tui-layout.exp +++ b/gdb/testsuite/gdb.tui/tui-layout.exp @@ -61,6 +61,10 @@ proc test_layout_or_focus {layout_name terminal execution} { } if {$dumb_terminal} { + if { [is_remote host] } { + # setenv TERM dummy has no effect on remote host. + return + } gdb_test "layout $layout_name" \ "Cannot enable the TUI: terminal doesn't support cursor addressing \\\[TERM=dumb\\\]" } else { -- 2.35.3