From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 3D05D3858C00 for ; Mon, 13 Mar 2023 16:20:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3D05D3858C00 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9694E1FE14 for ; Mon, 13 Mar 2023 16:20:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1678724452; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xn69a5N9E7pxuUgQe8hlGfbkHlwR1G1JO3I7J1X8Rc4=; b=laiYmPHuEWbM7xSgS78m7O0nLuwiNLFmjctBHFSpA/BB6u+TVHJDThVLpjn30RdMTTtDE9 cFHUV+SDP+iH12PZtbxhUYixi8mOwGoc0lAQJbO2B61y9nHVZnRFl65diunPXI2Zp5GSMt uxTy6eEddWXldK46c5MQsaoWdH4Fwls= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1678724452; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xn69a5N9E7pxuUgQe8hlGfbkHlwR1G1JO3I7J1X8Rc4=; b=6Wxsengg3kRKSUmYhuOgQSxhlGK8NdySW07mnfgrWga+/dvGh9kj6QI2GF+owAJMCNMyv9 VeZoZFsOzxLMFACA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8427513517 for ; Mon, 13 Mar 2023 16:20:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id UFQUH2RND2QbDAAAMHmgww (envelope-from ) for ; Mon, 13 Mar 2023 16:20:52 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [pushed 8/8] [gdb/testsuite] Fix gdb.python/tui-window-factory.exp for remote host Date: Mon, 13 Mar 2023 17:20:51 +0100 Message-Id: <20230313162051.488-9-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230313162051.488-1-tdevries@suse.de> References: <20230313162051.488-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: When running gdb.python/tui-window.exp with host board local-remote-host-notty and target board native-gdbserver, I get: ... FAIL: gdb.python/tui-window-factory.exp: msg_2: \ check test_window box (box check: ul corner is l, not +) ... The problem is that the result of Term::prepare_for_tui is not checked. Fix this by adding the missing check. Tested on x86_64-linux. --- gdb/testsuite/gdb.python/tui-window-factory.exp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.python/tui-window-factory.exp b/gdb/testsuite/gdb.python/tui-window-factory.exp index 3e898d01c7b..e3b403bdea0 100644 --- a/gdb/testsuite/gdb.python/tui-window-factory.exp +++ b/gdb/testsuite/gdb.python/tui-window-factory.exp @@ -32,7 +32,10 @@ set pyfile [gdb_remote_download host \ ${srcdir}/${subdir}/${gdb_test_file_name}.py] Term::clean_restart 24 80 -Term::prepare_for_tui +if { ![Term::prepare_for_tui] } { + unsupported "TUI not supported" + return +} gdb_test "source ${pyfile}" "Python script imported" \ "import python scripts" -- 2.35.3