From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Subject: [PATCH v2 7/8] Use bool and early loop exit in remove_extra_symbols
Date: Fri, 07 Apr 2023 10:40:00 -0600 [thread overview]
Message-ID: <20230314-submit-pragma-import-export-v2-7-dcff927191fb@adacore.com> (raw)
In-Reply-To: <20230314-submit-pragma-import-export-v2-0-dcff927191fb@adacore.com>
This changes remove_extra_symbols to use bool rather than int, and
changes the nested loops to exit early when "remove_p" is set.
---
gdb/ada-lang.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index 5d0ba5ac20b..091faba3037 100644
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -5040,7 +5040,7 @@ remove_extra_symbols (std::vector<struct block_symbol> &syms)
i = 0;
while (i < syms.size ())
{
- int remove_p = 0;
+ bool remove_p = false;
/* If two symbols have the same name and one of them is a stub type,
the get rid of the stub. */
@@ -5048,14 +5048,14 @@ remove_extra_symbols (std::vector<struct block_symbol> &syms)
if (syms[i].symbol->type ()->is_stub ()
&& syms[i].symbol->linkage_name () != NULL)
{
- for (j = 0; j < syms.size (); j++)
+ for (j = 0; !remove_p && j < syms.size (); j++)
{
if (j != i
&& !syms[j].symbol->type ()->is_stub ()
&& syms[j].symbol->linkage_name () != NULL
&& strcmp (syms[i].symbol->linkage_name (),
syms[j].symbol->linkage_name ()) == 0)
- remove_p = 1;
+ remove_p = true;
}
}
@@ -5066,7 +5066,7 @@ remove_extra_symbols (std::vector<struct block_symbol> &syms)
&& syms[i].symbol->aclass () == LOC_STATIC
&& is_nondebugging_type (syms[i].symbol->type ()))
{
- for (j = 0; j < syms.size (); j += 1)
+ for (j = 0; !remove_p && j < syms.size (); j += 1)
{
if (i != j
&& syms[j].symbol->linkage_name () != NULL
@@ -5076,7 +5076,7 @@ remove_extra_symbols (std::vector<struct block_symbol> &syms)
== syms[j].symbol->aclass ())
&& syms[i].symbol->value_address ()
== syms[j].symbol->value_address ())
- remove_p = 1;
+ remove_p = true;
}
}
--
2.39.1
next prev parent reply other threads:[~2023-04-07 16:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 16:39 [PATCH v2 0/8] Implement Ada Pragma Import and Pragma Export Tom Tromey
2023-04-07 16:39 ` [PATCH v2 1/8] Introduce lookup_minimal_symbol_linkage Tom Tromey
2023-04-07 16:39 ` [PATCH v2 2/8] Bump MAX_SYMBOL_IMPLS Tom Tromey
2023-04-07 16:39 ` [PATCH v2 3/8] Define symbol::value_block separately Tom Tromey
2023-04-07 16:39 ` [PATCH v2 4/8] Introduce symbol_block_ops::get_block_value Tom Tromey
2023-04-07 16:39 ` [PATCH v2 5/8] Handle Ada Pragma Import and Pragma Export Tom Tromey
2023-04-07 16:39 ` [PATCH v2 6/8] Use reference parameter in remove_extra_symbols Tom Tromey
2023-04-07 16:40 ` Tom Tromey [this message]
2023-04-07 16:40 ` [PATCH v2 8/8] Fix regression due to Pragma Import series Tom Tromey
2023-05-12 19:25 ` [PATCH v2 0/8] Implement Ada Pragma Import and Pragma Export Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230314-submit-pragma-import-export-v2-7-dcff927191fb@adacore.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).