From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [RFC 1/3] [gdb/dap] Add logging of ignored lines
Date: Tue, 14 Mar 2023 14:05:33 +0100 [thread overview]
Message-ID: <20230314130535.6369-2-tdevries@suse.de> (raw)
In-Reply-To: <20230314130535.6369-1-tdevries@suse.de>
This input sequence is accepted by DAP:
...
{"seq": 4, "type": "request", "command": "configurationDone"}Content-Length: 84
...
This input sequence has the same effect:
...
{"seq": 4, "type": "request", "command": "configurationDone"}ignorethis
Content-Length: 84
...
but the 'ignorethis' part is silently ignored.
Log the ignored bit, such that we have:
...
READ: <<<{"seq": 4, "type": "request", "command": "configurationDone"}>>>
WROTE: <<<{"request_seq": 4, "type": "response", "command": "configurationDone"
, "success": true}>>>
+++ run
IGNORED: <<<b'ignorethis'>>>
...
---
gdb/python/lib/gdb/dap/io.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/gdb/python/lib/gdb/dap/io.py b/gdb/python/lib/gdb/dap/io.py
index 74cc82301d7..28f4d93ba46 100644
--- a/gdb/python/lib/gdb/dap/io.py
+++ b/gdb/python/lib/gdb/dap/io.py
@@ -14,8 +14,9 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.
import json
+import sys
-from .startup import start_thread, send_gdb
+from .startup import start_thread, send_gdb, log
def read_json(stream):
@@ -31,6 +32,8 @@ def read_json(stream):
if line.startswith(b"Content-Length:"):
line = line[15:].strip()
content_length = int(line)
+ continue
+ log("IGNORED: <<<%s>>>" % line)
data = bytes()
while len(data) < content_length:
new_data = stream.read(content_length - len(data))
--
2.35.3
next prev parent reply other threads:[~2023-03-14 13:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 13:05 [RFC 0/3] [gdb/dap] Handle DAP command files Tom de Vries
2023-03-14 13:05 ` Tom de Vries [this message]
2023-03-14 14:12 ` [RFC 1/3] [gdb/dap] Add logging of ignored lines Tom Tromey
2023-03-24 8:10 ` Tom de Vries
2023-03-14 13:05 ` [RFC 2/3] [gdb/dap] Allow Content-Length on separate line Tom de Vries
2023-03-14 14:13 ` Tom Tromey
2023-03-14 15:35 ` Tom de Vries
2023-05-05 13:09 ` Tom Tromey
2023-03-14 13:05 ` [RFC 3/3] [gdb/dap] Allow WAIT_FOR_EVENTS input Tom de Vries
2023-05-05 13:09 ` Tom Tromey
2023-05-05 14:01 ` Tom de Vries
2023-05-10 16:23 ` Tom Tromey
2023-05-10 16:29 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230314130535.6369-2-tdevries@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).