From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D23E63858C50 for ; Fri, 17 Mar 2023 22:21:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D23E63858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679091664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o9a2NLhBlhhoZqiQfw0oNs+2361iUxjvLOa3frmp+OM=; b=Z33eNnKB5o/hlpSZRHXerRll/83lr+E5qu0GK4wXR0P7q1u68TZlIral/5XZIJfXk+BDXX bX21sYIiFM9WjVgPAa3UaddLtIj8+x95Dr5RxDN1XREuOF8dWdhTez/xwJDreRGCR05QtX 7BvY4oOWtnXJlP4jstYrVKFDIyeQ2sE= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-456-ZdiL7U-wOeWFXQlymSvcyQ-1; Fri, 17 Mar 2023 18:21:01 -0400 X-MC-Unique: ZdiL7U-wOeWFXQlymSvcyQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 19C4A3C0E440; Fri, 17 Mar 2023 22:21:01 +0000 (UTC) Received: from f37-zws-nv (unknown [10.2.16.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 93675492B00; Fri, 17 Mar 2023 22:21:00 +0000 (UTC) Date: Fri, 17 Mar 2023 15:20:59 -0700 From: Kevin Buettner To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [PATCH] Make ui_out::do_progress_end 'private' Message-ID: <20230317152059.0f8b4c52@f37-zws-nv> In-Reply-To: <20230316193741.3804125-1-tromey@adacore.com> References: <20230316193741.3804125-1-tromey@adacore.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 16 Mar 2023 13:37:41 -0600 Tom Tromey via Gdb-patches wrote: > I noticed that ui_out::do_progress_end is public, just to support one > use in debuginfod-support.c. This patch makes it private, updates > progress_info to call it from its destructor, and finally changes > debuginfod-support.c to follow. > --- > gdb/debuginfod-support.c | 101 ++++++++++++++++++++++----------------- > gdb/ui-out.h | 8 ++-- > 2 files changed, 61 insertions(+), 48 deletions(-) LGTM. Kevin