public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [pushed] [gdb/testsuite] Use localhost instead of 127.0.0.1 for boards
Date: Tue, 21 Mar 2023 11:35:06 +0100	[thread overview]
Message-ID: <20230321103506.20851-1-tdevries@suse.de> (raw)

Some boards in gdb/testsuite/boards use the hardcoded ipv4 address "127.0.0.1".

Use instead "localhost".

Tested on x86_64-linux.
---
 gdb/testsuite/boards/local-remote-host-native.exp | 4 ++--
 gdb/testsuite/boards/local-remote-host.exp        | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/gdb/testsuite/boards/local-remote-host-native.exp b/gdb/testsuite/boards/local-remote-host-native.exp
index 2851eb09324..21680d84118 100644
--- a/gdb/testsuite/boards/local-remote-host-native.exp
+++ b/gdb/testsuite/boards/local-remote-host-native.exp
@@ -40,7 +40,7 @@ if { $board_type == "target" } {
 set GDB [file join [pwd] "../gdb"]
 verbose -log "Overriding setting of GDB to $GDB"
 
-set_board_info hostname 127.0.0.1
+set_board_info hostname localhost
 
 set_board_info username $env(USER)
 
@@ -65,7 +65,7 @@ save_vars {rsh_cmd res} {
     }
 }
 
-# The ssh key should be correctly set up that you ssh to 127.0.0.1
+# The ssh key should be correctly set up that you ssh to localhost
 # without having to type password.
 set_board_info rsh_prog /usr/bin/ssh
 set_board_info rcp_prog /usr/bin/scp
diff --git a/gdb/testsuite/boards/local-remote-host.exp b/gdb/testsuite/boards/local-remote-host.exp
index f265208ddd9..021b2203d33 100644
--- a/gdb/testsuite/boards/local-remote-host.exp
+++ b/gdb/testsuite/boards/local-remote-host.exp
@@ -24,7 +24,7 @@
 
 set GDB [file normalize [file join [pwd] "../gdb"]]
 
-set_board_info hostname 127.0.0.1
+set_board_info hostname localhost
 
 if { [info exists REMOTE_HOST_USERNAME] } {
     set_board_info username $REMOTE_HOST_USERNAME
@@ -50,7 +50,7 @@ if { [board_info $board username] != $env(USER) } {
 	chmod go-rx ."
 }
 
-# The ssh key should be correctly set up that you ssh to 127.0.0.1
+# The ssh key should be correctly set up that you ssh to localhost
 # without having to type password.
 set_board_info rsh_prog /usr/bin/ssh
 set_board_info rcp_prog /usr/bin/scp

base-commit: 96cabfaa4327de5387487ab7af8239aebc00230e
-- 
2.35.3


                 reply	other threads:[~2023-03-21 10:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230321103506.20851-1-tdevries@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).