public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [pushed] [gdb/testsuite] Remove ${board}_file from remote-stdio-gdbserver.exp
Date: Tue, 21 Mar 2023 12:47:45 +0100	[thread overview]
Message-ID: <20230321114745.31692-1-tdevries@suse.de> (raw)

Looking at the implementation of ${board}_file in remote-stdio-gdbserver.exp,
I don't see a relevant difference with the implementation of standard_file
in dejagnu.

Simplify the board by removing ${board}_file.

Tested on x86_64-linux, by running gdb.testsuite/board-sanity.exp.
---
 gdb/testsuite/boards/remote-stdio-gdbserver.exp | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/gdb/testsuite/boards/remote-stdio-gdbserver.exp b/gdb/testsuite/boards/remote-stdio-gdbserver.exp
index c4e29e402fe..1007b199106 100644
--- a/gdb/testsuite/boards/remote-stdio-gdbserver.exp
+++ b/gdb/testsuite/boards/remote-stdio-gdbserver.exp
@@ -86,14 +86,6 @@ proc get_target_remote_pipe_cmd { } {
     return "$rsh_cmd $gdbserver --once stdio $target_exec"
 }
 
-proc ${board}_file { dest op args } {
-    if { $op == "delete" } {
-	set res [remote_exec target "rm -f $args"]
-	return [lindex $res 0]
-    }
-    return [eval [list standard_file $dest $op] $args]
-}
-
 proc ${board}_spawn { board cmd } {
     global board_info
 

base-commit: 6ad0261323ae6df46439fc9bec312e21ed80397a
-- 
2.35.3


                 reply	other threads:[~2023-03-21 11:47 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230321114745.31692-1-tdevries@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).