From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id DAADD3858CDB for ; Thu, 23 Mar 2023 18:39:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DAADD3858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679596770; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tFyEwbdH9Ljox1Rd11zgttD2A7tUK3fUWnFPVa9wLFI=; b=c1MsRl/a0m+GeaaEOCHROoL0gLkGEcVTEttfzWXsrQGLYWtRnkB53yE9g2MseBW162ZC1J pVUnuNDLW6zzuwX3QcCa/y5GSTqjm0D0eGQ5DPib5ApRVCOSDBRMACExOX3ur9YEuViKNT 1OuDhS/PNgLcCu+ztssKHUPRAkQg0Fw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-168-0lSmO47fPXqX-I98tKteeQ-1; Thu, 23 Mar 2023 14:39:29 -0400 X-MC-Unique: 0lSmO47fPXqX-I98tKteeQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C1D9A855300; Thu, 23 Mar 2023 18:39:28 +0000 (UTC) Received: from f37-zws-nv (unknown [10.2.16.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7E84C1121314; Thu, 23 Mar 2023 18:39:28 +0000 (UTC) Date: Thu, 23 Mar 2023 11:39:27 -0700 From: Kevin Buettner To: Luis Machado Cc: gdb-patches@sourceware.org Subject: Re: [PATCH, v2] aarch64: Check for valid inferior thread/regcache before reading pauth registers Message-ID: <20230323113927.466085b3@f37-zws-nv> In-Reply-To: References: <20230316103904.1947447-1-luis.machado@arm.com> <20230323105619.9151-1-luis.machado@arm.com> <20230323112551.66e4da4f@f37-zws-nv> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 23 Mar 2023 18:32:31 +0000 Luis Machado wrote: > On 3/23/23 18:27, Luis Machado wrote: > > On 3/23/23 18:25, Kevin Buettner wrote: > >> On Thu, 23 Mar 2023 10:56:19 +0000 > >> Luis Machado via Gdb-patches wrote: > >> > >>> Changes in v2: > >>> > >>> - Dropped helper functions and used inferior_ptid/current_inferior () > >>> instead.__ Changes are now aarch64-specific. > >> > >> A bug which your patch fixes had been reported in Fedora bugzilla; see: > >> > >> https://bugzilla.redhat.com/show_bug.cgi?id=2177655 > >> > >> I made a scratch build using your v1 patch and one user reported the > >> bug fixed. > >> > >> I've looked over your v2 patch and it looks good to me. > > > > Thanks for testing. Andrew B. had pinged me about a report on his end. > > > > Hopefully we can get this sorted out soon, as it is quite annoying. > > > >> > >> Kevin > >> > > > > Worth mentioning that I plan to backport this fix to GDB 13.1, which might require a > slightly different patch because in GDB 13 this code is linux-specific instead of > OS-independent. In order to apply your v1 patch to (Fedora) GDB 13.1, I first cherry-picked commit 6d0020873de. I think it might make sense to do the same for the 13.1 branch. Kevin